fixed automation feature references #4840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Kreuzer <[email protected]>
|
Are the automation bundles now considered part of the default OH installation? If you get rid of the core / api feature separation, MQTT and the eclipse marketplace and any other addon that provides Actions will pull in automation now, correct? |
Yes, right. So actually we should be able to remove the reference here completely as all add-ons should only use it as optional imports. |
Signed-off-by: Kai Kreuzer <[email protected]>
|
-> removed dependency. |
cweitkamp
approved these changes
Feb 9, 2019
davidgraeff
approved these changes
Feb 9, 2019
jannegpriv
pushed a commit
to jannegpriv/openhab-addons
that referenced
this pull request
Mar 3, 2019
* fixed automation feature references * removed feature dependency from add-ons Signed-off-by: Kai Kreuzer <[email protected]>
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Jun 19, 2019
* fixed automation feature references * removed feature dependency from add-ons Signed-off-by: Kai Kreuzer <[email protected]> Signed-off-by: Pshatsillo <[email protected]>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
* fixed automation feature references * removed feature dependency from add-ons Signed-off-by: Kai Kreuzer <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes openhab/openhab-distro#865
Fixes #4841
Signed-off-by: Kai Kreuzer [email protected]