Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tesla] Fixes #4230: Chargecable channel is a string, not a decimal. #4824

Merged
merged 1 commit into from
Feb 17, 2019

Conversation

cguedel
Copy link
Contributor

@cguedel cguedel commented Feb 6, 2019

Signed-off-by: Christian Güdel [email protected]

@martinvw
Copy link
Member

martinvw commented Feb 7, 2019

Thanks for your PR!

Did you test it locally and can you provide a jar to allow others to test locally, thanks!

Edit: Nevermind that is pending in the linked issue!

@martinvw
Copy link
Member

@cguedel please ping us if/when the solution is tested and confirmed.

Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

I think we are safe and can merge this as it is a small patch and the channel type definition for chargecable uses item type String too.

https://github.com/openhab/openhab2-addons/blob/328f4868b86009d2dfd1485222f996f06d3c5953/addons/binding/org.openhab.binding.tesla/ESH-INF/thing/models.xml#L229-L231

@cweitkamp cweitkamp merged commit 826b0f4 into openhab:master Feb 17, 2019
@wborn wborn added this to the 2.5 milestone Feb 28, 2019
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Jun 19, 2019
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants