[Network] Present used arping tool to user #4821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: davidgraeff <[email protected]>
martinvw
approved these changes
Feb 6, 2019
| arpPingMethod = ArpPingUtilEnum.UNKNOWN_TOOL; | ||
| return; | ||
| } | ||
| arpPingMethod = networkUtils.determineNativeARPpingMethod(arpPingUtilPath); | ||
| switch (arpPingMethod) { | ||
| case UNKNOWN_TOOL: { | ||
| arpPingState = "Unknown arping tool"; |
There was a problem hiding this comment.
You could also store these strings in the enum, then they are closer together, or maybe using a map. This could also work but imho the other options are a little bit more elegant.
There was a problem hiding this comment.
I might want to apply I18n at some point and thus not hardcoding the strings into the Enum. I do not expect that enum to change a lot, and if it falls through, there is just no name exposed to the user.
jannegpriv
pushed a commit
to jannegpriv/openhab-addons
that referenced
this pull request
Mar 3, 2019
Signed-off-by: davidgraeff <[email protected]>
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Jun 19, 2019
Signed-off-by: davidgraeff <[email protected]> Signed-off-by: Pshatsillo <[email protected]>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
Signed-off-by: davidgraeff <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: davidgraeff [email protected]