[modbus] update time-of-last-update

[ssalonen]

Fixes sloppy modification based on code review comment (which was valid on its own) from a maintainer, which lead to situation that "time of last update" was not kept up-to-date.

cc @martinvw

Signed-off-by: Sami Salonen [email protected]

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/solved-many-100-modbus-pollers-is-it-slowing-down-the-binding/53496/103

[cweitkamp]

@ssalonen Can you please check why Travis did not build your latest changes? Thanks

[ERROR] /home/travis/build/openhab/openhab2-addons/addons/binding/org.openhab.binding.modbus/src/main/java/org/openhab/binding/modbus/internal/handler/ModbusDataThingHandler.java:[873] 
[ERROR] 	channelLastUpdated.put(uid, now);
[ERROR] 	                            ^^^
[ERROR] now cannot be resolved to a variable

[ssalonen]

@cweitkamp thanks -- and I thought I could update single line without full IDE :) Will make sure the tests pass and the report back.

[ssalonen]

CI issues: https://ci.openhab.org/job/PR-openHAB2-Addons/12353/console

Possibly due to https://github.com/openhab/openhab2-addons/pull/4809 . See especially this comment. Rebasing...

Downloaded artifact https://ci.openhab.org/artifactory/libs-snapshot/org/openhab/pom-tycho/2.5.0-SNAPSHOT/maven-metadata.xml
Downloaded artifact https://ci.openhab.org/artifactory/libs-snapshot/org/openhab/pom-tycho/2.5.0-SNAPSHOT/maven-metadata.xml
ERROR: Failed to parse POMs
org.apache.maven.project.ProjectBuildingException: Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for org.eclipse.smarthome.model:org.eclipse.smarthome.model.sitemap:jar must be a valid version but is '${esh.version}'. @ line 30, column 16
[ERROR] 'dependencies.dependency.version' for org.eclipse.smarthome.ui:org.eclipse.smarthome.ui:jar must be a valid version but is '${esh.version}'. @ line 35, column 16
[ERROR] 'dependencies.dependency.version' for org.eclipse.smarthome.ui:org.eclipse.smarthome.ui.icon:jar must be a valid version but is '${esh.version}'. @ line 40, column 16
[ERROR] 'dependencies.dependency.version' for org.eclipse.smarthome.model:org.eclipse.smarthome.model.sitemap:jar must be a valid version but is '${esh.version}'. @ line 35, column 16
[ERROR] 'dependencies.dependency.version' for org.eclipse.smarthome.ui:org.eclipse.smarthome.ui:jar must be a valid version but is '${esh.version}'. @ line 40, column 16
[ERROR] 'dependencies.dependency.version' for org.eclipse.smarthome.ui:org.eclipse.smarthome.ui.icon:jar must be a valid version but is '${esh.version}'. @ line 45, column 16
[ERROR] 'dependencies.dependency.version' for org.eclipse.smarthome:esh-core:xml:features must be a valid version but is '${esh.version}'. @ line 28, column 16
[ERROR] 'dependencies.dependency.version' for org.eclipse.smarthome:esh-tp:xml:features must be a valid version but is '${esh.version}'. @ line 35, column 16
[ERROR] 'dependencies.dependency.version' for org.eclipse.smarthome:esh-ext:xml:features must be a valid version but is '${esh.version}'. @ line 42, column 16

	at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:364)
	at org.jfrog.build.extractor.maven.ArtifactoryProjectBuilder.build(ArtifactoryProjectBuilder.java:31)
	at hudson.maven.MavenEmbedder.buildProjects(MavenEmbedder.java:361)
	at hudson.maven.MavenEmbedder.readProjects(MavenEmbedder.java:331)
	at hudson.maven.MavenModuleSetBuild$PomParser.invoke(MavenModuleSetBuild.java:1328)
	at hudson.maven.MavenModuleSetBuild$PomParser.invoke(MavenModuleSetBuild.java:1125)
	at hudson.FilePath.act(FilePath.java:1078)
	at hudson.FilePath.act(FilePath.java:1061)
	at hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.parsePoms(MavenModuleSetBuild.java:986)
	at hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.doRun(MavenModuleSetBuild.java:691)
	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:504)
	at hudson.model.Run.execute(Run.java:1810)
	at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:543)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:429)
[htmlpublisher] Archiving HTML reports...
[htmlpublisher] Archiving at BUILD level /var/jenkins_home/workspace/PR-openHAB2-Addons/target to /var/jenkins_home/jobs/PR-openHAB2-Addons/builds/12353/htmlreports/Static_20Code_20Analysis_20Report
Finished: FAILURE

[ssalonen]

Dependency issues still: https://ci.openhab.org/job/PR-openHAB2-Addons/12354/

Could it be that org.openhab.core is some old snapshot that still refers to org.eclipse.smarthome.ui?

1) org.eclipse.smarthome.ui:org.eclipse.smarthome.ui:jar:${esh.version}

  Try downloading the file manually from the project website.

  Then, install it using the command: 
      mvn install:install-file -DgroupId=org.eclipse.smarthome.ui -DartifactId=org.eclipse.smarthome.ui -Dversion=${esh.version} -Dpackaging=jar -Dfile=/path/to/file

  Alternatively, if you host your own repository you can deploy the file there: 
      mvn deploy:deploy-file -DgroupId=org.eclipse.smarthome.ui -DartifactId=org.eclipse.smarthome.ui -Dversion=${esh.version} -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]

  Path to dependency: 
  	1) org.openhab.binding:org.openhab.binding.modbus:pom:2.5.0-SNAPSHOT
  	2) org.openhab.io:org.openhab.io.transport.modbus:jar:2.5.0-SNAPSHOT
  	3) org.openhab.core:org.openhab.core:jar:2.5.0-SNAPSHOT
  	4) org.eclipse.smarthome.ui:org.eclipse.smarthome.ui:jar:${esh.version}

[martinvw]

Travis being green is good enough for now 👍

[martinvw]

Thanks!