Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miio] update readme #4780

Merged
merged 1 commit into from
Feb 13, 2019
Merged

[miio] update readme #4780

merged 1 commit into from
Feb 13, 2019

Conversation

marcelrv
Copy link
Contributor

@marcelrv marcelrv commented Feb 2, 2019

Update readme
Signed-off-by: Marcel Verpaalen [email protected]

Copy link
Contributor

@Confectrician Confectrician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marcelrv,

Thanks for your improvements.
Just some small style comments aside.

BR
Jerome

@@ -926,6 +927,15 @@ e.g. `smarthome:send actionCommand 'upd_timer["1498595904821", "on"]'` would ena
| led | Switch | Wifi led |


### Mi Power-plug (<a name="chuangmi-plug-m3">chuangmi.plug.m3</a>) Channels

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line could be removed.

|------------------|---------|-------------------------------------|
| power | Switch | Power |
| temperature | Number | Temperature |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line could be removed.

@@ -2173,6 +2183,16 @@ Number temperature "Temperature" (G_plug) {channel="miio:basic:plug:temperature"
Switch led "Wifi led" (G_plug) {channel="miio:basic:plug:led"}
```

### Mi Power-plug (chuangmi.plug.m3) item file lines

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line could be removed.



note: Autogenerated example. Replace the id (plug) in the channel with your own. Replace `basic` with `generic` in the thing UID depending on how your thing was discovered.
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a newline before the codeblock and add a language like ```java

@marcelrv
Copy link
Contributor Author

marcelrv commented Feb 4, 2019

@Confectrician are you 100% sure that without these blank lines it will work with Jekyll. Before it caused some issues...
https://github.com/openhab/openhab2-addons/issues/956

@Confectrician
Copy link
Contributor

We don't use jekyll anymore for the website build, so keeping just one newline should be fine.

I am sure the code blocks would even work without any newline too, but the empty lines between a paragraph and codeblocks/headlines, have evolved to a kind of styleguide now.
So the reason for suggesting this is, to keep the files consistenst (and hopefully get rid of inconsistent ones in a future far away).

I have asked the other documentation maintainers how we have to (or should) handle the code block language tags in the future.
I think vupress (our current webstie/docs backend) doesn't need a special language tag for the codeblocks, but again we should try to be consistent here.
So i might suggested the wrong language in this case but that should be no problem for now.

Signed-off-by: Marcel Verpaalen <[email protected]>
@marcelrv
Copy link
Contributor Author

as your remarks basically apply to the rest of the readme as well it is updated for the other items as well

Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp merged commit 423c92c into openhab:master Feb 13, 2019
@wborn wborn added this to the 2.5 milestone Feb 28, 2019
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Jun 19, 2019
Signed-off-by: Marcel Verpaalen <[email protected]>
Signed-off-by: Pshatsillo <[email protected]>
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
Signed-off-by: Marcel Verpaalen <[email protected]>
Signed-off-by: Maximilian Hess <[email protected]>
@wborn wborn removed this from the 2.5 milestone Dec 8, 2019
@marcelrv marcelrv deleted the miio-readmeUpdate branch December 13, 2019 00:59
@wborn wborn added this to the 2.5 milestone Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants