[onkyo] Added TXNR575 to devices per issue 4750 #4757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wborn
changed the title
cweitkamp
requested changes
Jan 30, 2019
There was a problem hiding this comment.
Thank you very much for your first contribution.
Can you please add the device to the README.md?
Might I ask you to sign-off your commit? (see https://www.openhab.org/docs/developer/contributing/contributing.html#sign-your-work).
|
Fixed the README.md. I am a bit confused...should I add the sign-off line here, or in a git commit message? |
|
You can add it in a comment this time. Better way is to add it in your commits messages next time. |
|
Signed-off-by: Joe Inkenbrandt [email protected] |
wborn
approved these changes
Jan 30, 2019
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Jun 19, 2019
* Added TXNR575 to devices per issue 4750 * Added TXNR575 to README.md Signed-off-by: Joe Inkenbrandt <[email protected]> Signed-off-by: Pshatsillo <[email protected]>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
* Added TXNR575 to devices per issue 4750 * Added TXNR575 to README.md Signed-off-by: Joe Inkenbrandt <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in Issue #4750, this simply adds the TXNR575 to the device list. Code has been tested and is working.
Closes #4750