[miio] Fix issue battery channel #4752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix error for devices with battery channel - Add chungmi plug m3 - minor edits Signed-off-by: Marcel Verpaalen <[email protected]>
cweitkamp
reviewed
Jan 29, 2019
| @@ -35,6 +35,7 @@ | |||
| SHUTTING_DOWN(13, "Shutting Down"), | |||
| UPDATING(14, "Updating"), | |||
| DOCKING(15, "Docking"), | |||
| GOTO(15, "Go To"), | |||
There was a problem hiding this comment.
Do you mean 16? 15 is used twice.
| @@ -15,6 +15,8 @@ | |||
| import java.util.ArrayList; | |||
| import java.util.List; | |||
|
|
|||
| import org.openhab.binding.miio.internal.MiIoBindingConstants; | |||
There was a problem hiding this comment.
Can you please make this a static import?
There was a problem hiding this comment.
thanks for the feedback.
improvement based on review Signed-off-by: Marcel Verpaalen <[email protected]>
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Jun 19, 2019
* Fix issue battery channel - Fix error for devices with battery channel - Add chungmi plug m3 - minor edits Signed-off-by: Marcel Verpaalen <[email protected]> Signed-off-by: Pshatsillo <[email protected]>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
* Fix issue battery channel - Fix error for devices with battery channel - Add chungmi plug m3 - minor edits Signed-off-by: Marcel Verpaalen <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marcel Verpaalen [email protected]