Remove static "for the next 3 hours" text #4738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is applied to every forecast, no matter how far in the future.
cweitkamp
requested changes
Jan 28, 2019
There was a problem hiding this comment.
As mentioned in the other PR I agree with you on the labels for the forecast channel types. They are reused for hourly and daily forecast and will fit better. But I do not agree on the labels for the current channel types. According to the documentation the API returns exactly those values.
I marked one spelling mistake inside.
| @@ -112,8 +112,8 @@ Once the parameter `forecastDays` will be changed, the available channel groups | |||
| | forecastHours03, forecastHours06, ... forecastHours120 | wind-direction | Number:Angle | Forecasted wind direction. | | |||
| | forecastHours03, forecastHours06, ... forecastHours120 | gust-speed | Number:Speed | Forecasted gust speed. **Advanced** | | |||
| | forecastHours03, forecastHours06, ... forecastHours120 | cloudiness | Number:Dimensionless | Forecasted cloudiness. | | |||
| | forecastHours03, forecastHours06, ... forecastHours120 | rain | Number:Length | Expected rain volume for the next 3 hours. | | |||
| | forecastHours03, forecastHours06, ... forecastHours120 | snow | Number:Length | Expected snow volume for the next 3 hours. | | |||
| | forecastHours03, forecastHours06, ... forecastHours120 | rain | Number:Length | Expected rain volum. | | |||
There was a problem hiding this comment.
Ok, fixed that one. Must have been slipped through, as the white space was also missing.
|
I restored the labels for the current weather data. |
cweitkamp
approved these changes
Jan 28, 2019
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Jun 19, 2019
* Remove static "for the next 3 hours" text. This is applied to every forecast, no matter how far in the future. Signed-off-by: Pshatsillo <[email protected]>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
* Remove static "for the next 3 hours" text. This is applied to every forecast, no matter how far in the future. Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is applied to every forecast, no matter how far in the future.