Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[network] fix discovery service #4729

Merged
merged 2 commits into from
Jan 27, 2019
Merged

[network] fix discovery service #4729

merged 2 commits into from
Jan 27, 2019

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jan 27, 2019

Fixes #4559

Signed-off-by: Jan N. Klug [email protected]

@J-N-K
fix discovery service
c56af9a 
Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K J-N-K requested a review from davidgraeff as a code owner January 27, 2019 13:58
@davidgraeff
Copy link
Member

Perfect. Thanks. If time permits, could you please add to the deactivate method an executor.shutdown() so that we don't leak any resources behind?

@J-N-K
shutdown executor service
6eb3b9c 
Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K
Copy link
Member Author

J-N-K commented Jan 27, 2019

Thanks. I only checked that the executorService is shutdown in stopScan.

@J-N-K
Copy link
Member Author

J-N-K commented Jan 27, 2019

Jenkins faiuls in max.test.

@davidgraeff davidgraeff merged commit 87aa430 into openhab:master Jan 27, 2019
@J-N-K J-N-K deleted the network-fix-discovery branch January 27, 2019 16:26
@J-N-K J-N-K mentioned this pull request Feb 4, 2019
Closed
@wborn wborn added this to the 2.5 milestone Feb 28, 2019
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/synology-fritz-box-no-ping-allowed-cannot-add-my-iphone-via-network-binding/71444/2

Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Jun 19, 2019
@J-N-K @Pshatsillo
[network] fix discovery service (openhab#4729)
3f79c1e 
* fix discovery service
* shutdown executor service

Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Pshatsillo <[email protected]>
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
@J-N-K @ne0h
[network] fix discovery service (openhab#4729)
089b2d8 
* fix discovery service
* shutdown executor service

Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidgraeff davidgraeff davidgraeff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.
4 participants
@J-N-K @davidgraeff @openhab-bot @wborn