[hue] Added configuration for port #4728

cweitkamp · 2019-01-27T11:59:45Z

Added configuration for port

Continues eclipse-archived/smarthome#6854

Signed-off-by: Christoph Weitkamp [email protected]

cweitkamp · 2019-01-27T12:03:41Z

@martinvw Can you give me a hand on the TlsTrustManager implementations? For now I tries to follow the approach of the unifi binding including a "trust all" manager. Thanks.

The Philips Hue certificate looks like this - but I do not know if it is sufficient because the idea behind this PR is to allow the Hue binding to connect to similar Hue APIs like deCONZ too.

Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number: 6624557528005837 (0x1788fffe403ccd)
    Signature Algorithm: ecdsa-with-SHA256
        Issuer: C = NL, O = Philips Hue, CN = 001788fffe403ccd
        Validity
            Not Before: Jan  1 00:00:00 2017 GMT
            Not After : Jan  1 00:00:00 2038 GMT
        Subject: C = NL, O = Philips Hue, CN = 001788fffe403ccd
        Subject Public Key Info:
            Public Key Algorithm: id-ecPublicKey
                Public-Key: (256 bit)
                pub:
                    04:64:1f:2f:c1:10:62:bf:fc:f1:aa:9d:41:57:e8:
                    46:db:d1:49:9d:f0:6c:02:cf:cf:70:9e:ec:2f:9e:
                    d4:e3:e7:ce:81:c4:20:a3:f2:2a:af:75:3a:be:c7:
                    7b:58:f4:4a:f8:71:e8:3b:24:a1:2a:19:52:1d:91:
                    4b:01:41:14:e2
                ASN1 OID: prime256v1
                NIST CURVE: P-256
        X509v3 extensions:
            X509v3 Basic Constraints: critical
                CA:FALSE
            X509v3 Subject Key Identifier: 
                38:C8:28:A2:62:A4:AC:2A:53:83:21:4D:EF:67:2D:D3:68:EE:C5:AB
            X509v3 Authority Key Identifier: 
                keyid:38:C8:28:A2:62:A4:AC:2A:53:83:21:4D:EF:67:2D:D3:68:EE:C5:AB
                DirName:/C=NL/O=Philips Hue/CN=001788fffe403ccd
                serial:17:88:FF:FE:40:3C:CD

            X509v3 Key Usage: critical
                Digital Signature, Key Encipherment
            X509v3 Extended Key Usage: 
                TLS Web Server Authentication
    Signature Algorithm: ecdsa-with-SHA256
         30:46:02:21:00:e4:f8:51:c4:84:80:a6:c6:4a:95:38:b2:f2:
         e3:e4:79:56:b4:b0:32:6e:27:e3:56:61:84:c5:4b:f4:85:48:
         3a:02:21:00:ec:f3:07:d5:f7:53:8a:90:83:11:ba:5e:e0:e5:
         d3:89:de:4e:8e:d4:95:7c:0b:ad:e1:a6:48:17:06:d4:8d:40

Current state is that HTTPS is not working because of this exception:

org.openhab.binding.hue.internal.exceptions.UnauthorizedException: javax.net.ssl.SSLHandshakeException: java.security.cert.CertificateException: No subject alternative names present
	at org.openhab.binding.hue.internal.HueBridge.authenticate(HueBridge.java:833) ~[232:org.openhab.binding.hue:2.5.0.201901271145]
	at org.openhab.binding.hue.internal.handler.HueBridgeHandler.onNotAuthenticated(HueBridgeHandler.java:495) [232:org.openhab.binding.hue:2.5.0.201901271145]
	at org.openhab.binding.hue.internal.handler.HueBridgeHandler$PollingRunnable.run(HueBridgeHandler.java:106) [232:org.openhab.binding.hue:2.5.0.201901271145]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:?]
	at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) [?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) [?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) [?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:?]
	at java.lang.Thread.run(Thread.java:748) [?:?]

cweitkamp · 2019-01-27T12:11:06Z

...hab.binding.hue/src/main/java/org/openhab/binding/hue/internal/handler/HueBridgeHandler.java

@@ -534,6 +535,7 @@ private void updateBridgeThingConfiguration(String userName) {
    }

    private void handleAuthenticationFailure(Exception ex, String userName) {
+        logger.debug("{}", ex);


To be removed after we found a solution for the occurring exception.

davidgraeff · 2019-02-06T20:12:34Z

Before we run into merge conflicts at some point, can we merge this? At least the port fix looks good and https needs further tests, I agree. But better having that in the main tree than rotting, I guess?

cweitkamp · 2019-02-06T21:55:11Z

I thought about splitting this up into two separate PRs. One for the port and one for the HTTPS connection. I'll be the nicest way.

Signed-off-by: Christoph Weitkamp <[email protected]>

cweitkamp · 2019-02-07T07:10:08Z

@davidgraeff I removed all HTTPS related changes which were visible for the user and obsolete code.

martinvw · 2019-02-07T10:54:00Z

...inding/org.openhab.binding.hue/src/main/java/org/openhab/binding/hue/internal/HueBridge.java

+        try {
+            URI uri = new URI(protocol, null, ip, port, path.isEmpty() ? basePath : basePath + "/" + path, null, null);
+            return uri.toString();
+        } catch (URISyntaxException e) {


Should we do some logging here? Its unlikely that the url is correct?

Yes, I will. And I will do a second change: I will move the creation of the URI into the constructor. It is sufficient to resolve it once and not every time we want to connect to the Hue API.

Done. But let me test it for at least one day before we merge.

Signed-off-by: Christoph Weitkamp <[email protected]>

cweitkamp · 2019-02-09T13:08:32Z

But let me test it for at least one day before we merge.

It looks fine. Works smoothly without unexpected errors. I will give it a go.

davidgraeff · 2019-02-09T13:37:55Z

I'll merge it in then. The hue binding is really causing havoc on my system because of it constantly forgetting the port at the moment (and colliding with hue emulation therefore).

* Added configuration for port and protocol Signed-off-by: Christoph Weitkamp <[email protected]>

* Added configuration for port and protocol Signed-off-by: Christoph Weitkamp <[email protected]> Signed-off-by: Pshatsillo <[email protected]>

* Added configuration for port and protocol Signed-off-by: Christoph Weitkamp <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>

ghost

N

cweitkamp added the work in progress A PR that is not yet ready to be merged label Jan 27, 2019

cweitkamp requested review from davidgraeff and martinvw January 27, 2019 11:59

cweitkamp requested a review from lolodomo as a code owner January 27, 2019 11:59

cweitkamp commented Jan 27, 2019

View reviewed changes

davidgraeff approved these changes Feb 6, 2019

View reviewed changes

cweitkamp removed the request for review from lolodomo February 7, 2019 06:53

cweitkamp added 2 commits February 7, 2019 08:02

Added configuration for port and protocol

4f59549

Signed-off-by: Christoph Weitkamp <[email protected]>

Removed (visible) changes for HTTPS connection

472dbd5

Signed-off-by: Christoph Weitkamp <[email protected]>

cweitkamp force-pushed the bugfix-hue-port-and-protocol branch from 7597286 to 472dbd5 Compare February 7, 2019 07:06

cweitkamp changed the title ~~[hue][WIP] Added configuration for port and protocol~~ [hue][WIP] Added configuration for port Feb 7, 2019

cweitkamp changed the title ~~[hue][WIP] Added configuration for port~~ [hue] Added configuration for port Feb 7, 2019

cweitkamp removed the work in progress A PR that is not yet ready to be merged label Feb 7, 2019

davidgraeff approved these changes Feb 7, 2019

View reviewed changes

martinvw reviewed Feb 7, 2019

View reviewed changes

Incorporated changes from review

a2ad04e

Signed-off-by: Christoph Weitkamp <[email protected]>

cweitkamp force-pushed the bugfix-hue-port-and-protocol branch from 91984bb to a2ad04e Compare February 7, 2019 19:36

davidgraeff approved these changes Feb 9, 2019

View reviewed changes

davidgraeff merged commit 103300b into openhab:master Feb 9, 2019

cweitkamp deleted the bugfix-hue-port-and-protocol branch February 9, 2019 14:25

wborn added this to the 2.5 milestone Feb 28, 2019

jannegpriv pushed a commit to jannegpriv/openhab-addons that referenced this pull request Mar 3, 2019

[hue] Added configuration for port (openhab#4728)

cfc0a3c

* Added configuration for port and protocol Signed-off-by: Christoph Weitkamp <[email protected]>

cweitkamp added the enhancement An enhancement or new feature for an existing add-on label Dec 14, 2019

ghost reviewed Dec 12, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[hue] Added configuration for port #4728

[hue] Added configuration for port #4728

cweitkamp commented Jan 27, 2019 •

edited

Loading

cweitkamp commented Jan 27, 2019 •

edited

Loading

cweitkamp Jan 27, 2019 •

edited

Loading

davidgraeff commented Feb 6, 2019

cweitkamp commented Feb 6, 2019

cweitkamp commented Feb 7, 2019 •

edited

Loading

martinvw Feb 7, 2019

cweitkamp Feb 7, 2019

cweitkamp Feb 7, 2019

cweitkamp commented Feb 9, 2019

davidgraeff commented Feb 9, 2019

ghost left a comment

[hue] Added configuration for port #4728

[hue] Added configuration for port #4728

Conversation

cweitkamp commented Jan 27, 2019 • edited Loading

cweitkamp commented Jan 27, 2019 • edited Loading

cweitkamp Jan 27, 2019 • edited Loading

Choose a reason for hiding this comment

davidgraeff commented Feb 6, 2019

cweitkamp commented Feb 6, 2019

cweitkamp commented Feb 7, 2019 • edited Loading

martinvw Feb 7, 2019

Choose a reason for hiding this comment

cweitkamp Feb 7, 2019

Choose a reason for hiding this comment

cweitkamp Feb 7, 2019

Choose a reason for hiding this comment

cweitkamp commented Feb 9, 2019

davidgraeff commented Feb 9, 2019

ghost left a comment

Choose a reason for hiding this comment

cweitkamp commented Jan 27, 2019 •

edited

Loading

cweitkamp commented Jan 27, 2019 •

edited

Loading

cweitkamp Jan 27, 2019 •

edited

Loading

cweitkamp commented Feb 7, 2019 •

edited

Loading