Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[homekit] Use DS annotations and fix SAT findings #4722

Merged
merged 1 commit into from
Jan 26, 2019
Merged

[homekit] Use DS annotations and fix SAT findings #4722

merged 1 commit into from
Jan 26, 2019

Conversation

wborn
Copy link
Member

@wborn wborn commented Jan 26, 2019

  • Use DS annotations
  • Fix SAT findings
  • Fix Eclipse library path

@wborn wborn requested a review from andylintner as a code owner January 26, 2019 18:47
cweitkamp
cweitkamp approved these changes Jan 26, 2019
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp merged commit fcb81db into openhab:master Jan 26, 2019
@wborn wborn deleted the homekit-ds branch January 26, 2019 20:45
@wborn wborn added the homekit label Feb 25, 2019
@wborn wborn added this to the 2.5 milestone Feb 28, 2019
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Jun 19, 2019
@wborn @Pshatsillo
[homekit] Use DS annotations and fix SAT findings (openhab#4722)
18cbc72 
Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Pshatsillo <[email protected]>
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
@wborn @ne0h
[homekit] Use DS annotations and fix SAT findings (openhab#4722)
a62b4df 
Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitkamp cweitkamp cweitkamp approved these changes

@andylintner andylintner Awaiting requested review from andylintner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.
2 participants
@wborn @cweitkamp