[imperihome] Use DS annotations #4721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wouter Born <[email protected]>
martinvw
reviewed
Jan 26, 2019
| @@ -53,6 +60,11 @@ | |||
| * | |||
| * @author Pepijn de Geus - Initial contribution | |||
| */ | |||
| @Component(immediate = true, service = HttpServlet.class, configurationPid = "org.openhab.imperihome", property = { | |||
| org.osgi.framework.Constants.SERVICE_PID + "=org.openhab.imperihome", | |||
There was a problem hiding this comment.
Can this one also be imported? Or maybe a static import?
There was a problem hiding this comment.
It's now imported. A simple class import because that looks nicer because the auto-formatter would put multiple properties on the same line with a static import. :-)
Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Wouter Born <[email protected]>
martinvw
approved these changes
Jan 26, 2019
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Jun 19, 2019
* [imperihome] Use DS annotations Signed-off-by: Wouter Born <[email protected]> Signed-off-by: Pshatsillo <[email protected]>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
* [imperihome] Use DS annotations Signed-off-by: Wouter Born <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use DS annotations for generating the component XML.