[enocean] Add Ramping time to dimmer channel for central command #4585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Dominik Krickl-Vorreiter <[email protected]>
Signed-off-by: Dominik Krickl-Vorreiter <[email protected]>
Signed-off-by: Dominik Krickl-Vorreiter <[email protected]>
wborn
reviewed
Jan 23, 2019
...an/src/main/java/org/openhab/binding/enocean/internal/config/EnOceanChannelDimmerConfig.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Dominik Krickl-Vorreiter <[email protected]>
|
Thank you, @wborn, I have changed the header. Let me know if I can do anything more. |
wborn
approved these changes
Jan 27, 2019
There was a problem hiding this comment.
Thanks! Can you also create a PR to update the documentation for the new thing types and configuration options @dominikkv or @fruggy83 ?
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Jun 19, 2019
…nhab#4585) * Add ramping time to dimmer channel for central command * Add ramping time for D2-01-01 Signed-off-by: Dominik Krickl-Vorreiter <[email protected]> Signed-off-by: Pshatsillo <[email protected]>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
…nhab#4585) * Add ramping time to dimmer channel for central command * Add ramping time for D2-01-01 Signed-off-by: Dominik Krickl-Vorreiter <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ramping time for EEPs A5-38-08 CMD 0x02 and D2-01-01.
Signed-off-by: Dominik Krickl-Vorreiter [email protected]
closes #4584
See fruggy83/openocean#43