Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[loxone] Made constants and handler packages internal #3973

Merged
merged 1 commit into from
Jan 26, 2019
Merged

[loxone] Made constants and handler packages internal #3973

merged 1 commit into from
Jan 26, 2019

Conversation

VelinYordanov
Copy link

See eclipse-archived/smarthome#4330

Signed-off-by: VelinYordanov [email protected]

@cweitkamp
Copy link
Contributor

It looks like this PR will cause merge conflicts on #2905.

@wborn wborn added the awaiting other PR Depends on another PR label Sep 22, 2018
@wborn wborn changed the title Made constants and handler packages internal in the loxone binding [loxone] Made constants and handler packages internal Sep 22, 2018
@wborn wborn mentioned this pull request Oct 8, 2018
Merged
@cweitkamp cweitkamp added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 26, 2019
@cweitkamp
Copy link
Contributor

Restart Travis.

@cweitkamp cweitkamp closed this Jan 26, 2019
@cweitkamp cweitkamp reopened this Jan 26, 2019
cweitkamp
cweitkamp approved these changes Jan 26, 2019
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you both.

@cweitkamp cweitkamp removed the awaiting other PR Depends on another PR label Jan 26, 2019
@cweitkamp cweitkamp merged commit 5b6ffe7 into openhab:master Jan 26, 2019
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Jun 19, 2019
@VelinYordanov @Pshatsillo
[loxone] Made constants and handler packages internal in the loxone b…
aae0fec 
…inding (openhab#3973)

Signed-off-by: VelinYordanov <[email protected]>
Signed-off-by: Pshatsillo <[email protected]>
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
@VelinYordanov @ne0h
[loxone] Made constants and handler packages internal in the loxone b…
f83a020 
…inding (openhab#3973)

Signed-off-by: VelinYordanov <[email protected]>
Signed-off-by: Maximilian Hess <[email protected]>
@wborn wborn added this to the 2.5 milestone Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitkamp cweitkamp cweitkamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@VelinYordanov @cweitkamp @wborn