[draytonwiser] Drayton Wiser Binding initial contribution #3168

andrew-schofield · 2018-01-24T21:14:03Z

Add a new binding that supports the Drayton Wiser smart heating system.

Currently the binding supports auto-discovery, all current devices and most channels.
Some features are still in development, but the binding is usable currently, and has been tested on 4 different heating setups.

There's a discussion thread in the community here.

The development of this binding was mentioned in #3126.

jar file for testing:
https://openhab.jfrog.io/openhab/libs-pullrequest-local/org/openhab/binding/org.openhab.binding.draytonwiser/2.5.0-SNAPSHOT/org.openhab.binding.draytonwiser-2.5.0-SNAPSHOT.jar

openhab-bot · 2018-01-24T21:16:18Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/drayton-wiser-thermostat-binding/35640/72

andrew-schofield · 2018-01-31T22:16:24Z

Not sure why the fail state on Jenkins after my most recent commit. The log suggests that the maven JVM died at the end even though the compile completed successfully.

openhab-bot · 2018-02-01T16:28:45Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/drayton-wiser-thermostat-binding/35640/114

openhab-bot · 2018-02-01T19:25:16Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/drayton-wiser-thermostat-binding/35640/1

openhab-bot · 2018-03-15T08:13:13Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/drayton-wiser-thermostat-binding/35640/170

andrew-schofield · 2018-04-05T09:42:19Z

I really don't understand the random build system failures I'm seeing. Why are there errors in other plugins, when all I've changed is code in my plugin, and they passed last time?

andrew-schofield · 2018-04-25T08:27:57Z

This PR is no longer WIP and is ready for review. I am aware there are multiple commits that are missing the signed-off-by line, but given you're going to request that I squash all the commits before merging anyway, I don't see this as a blocker to review.

andrew-schofield · 2018-06-14T22:01:28Z

I've gone through and signed-off all the historic commits that were causing review errors.

openhab-bot · 2018-06-24T17:44:33Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/drayton-wiser-thermostat-binding/35640/199

triller-telekom

Thank you very much for writing this binding!

I made a first review where I just looked at the modeling of your things and channels. Once we find an agreement, I will continue by looking at the sources.

Please have a look at my comments inside the code and do not hesitate to ask if you have questions.

EDIT: if you make changes, please make them in additional commits. And if you like to integrate the newest changes from the master branch, please rebase your branch onto it, do not merge it.

addons/binding/org.openhab.binding.draytonwiser/OSGI-INF/.gitignore

...s/binding/org.openhab.binding.draytonwiser/OSGI-INF/DraytonWiserMDNSDiscoveryParticipant.xml

addons/binding/org.openhab.binding.draytonwiser/README.md

addons/binding/org.openhab.binding.draytonwiser/ESH-INF/thing/thing-types.xml

triller-telekom · 2018-07-23T12:39:07Z

I have answered some of you questions, please have a look.

Also please do not add further features to this PR like the smart plug you just added, because this makes the review more difficult. Otherwise if you plan to add more things before someoen reviews them, please change the name of this PR to "WIP" (work in progress).

andrew-schofield · 2018-07-29T20:06:09Z

I've sorted out most of the channel names and types etc. I haven't added UoM to any channels yet, nor have I removed the json channels.

Question: I tried to add humidity as a system channel, however when I tried to use the binding on my instance of 2.3.0 I got an error message about it not being a supported channel-type. Is system.atmospheric-humidity only in >=2.4.0?

triller-telekom · 2018-07-31T13:25:48Z

Thank you for sorting out the channel names so far.

To answer your question: Yes the system.atmospheric-humidity is very new and only available in 2.4.0-SNAPSHOT of openHAB so far.

andrew-schofield · 2018-08-03T21:59:02Z

I've just tried looking at the UoM documentation and some of the bindings that use it, and I'm afraid I'm thoroughly confused.
When I receive some data from the binding, like a temperature update, do I need to return a QuantityType(value, UnitOfReceivedValue)?
When I'm handling a command (like updating a setpoint), how do I convert the command value to the input unit I actually want?

triller-telekom · 2018-08-06T09:49:51Z

When I receive some data from the binding, like a temperature update, do I need to return a QuantityType(value, UnitOfReceivedValue)?

Yes, exactly.

When I'm handling a command (like updating a setpoint), how do I convert the command value to the input unit I actually want?

That depends on what type the command is and what kind of data your device expects... If you define the channel to only accept QuantityTypes then you know what value and unit it is. If you also allow DecimalTypes (Number instead of Number:UOM_Type) then you have to define what you do with that value.

andrew-schofield · 2018-08-12T21:18:13Z

OK, I've added UoM to all the channels I think I reasonably can, with the exception of humidity as I haven't set up a test 2.4.0 instance of openhab to make sure it works. I haven't disabled the schedule channel yet, as I'd like to be able to keep a way of updating a schedule, but I need to think about a better way of doing it.
The Jenkins failure appears to be because of a broken modbus binding on master :(

Signed-off-by: Andrew Schofield <[email protected]>

…utes Signed-off-by: Andrew Schofield <[email protected]>

…ng quantity type Signed-off-by: Andrew Schofield <[email protected]>

… duration Signed-off-by: Andrew Schofield <[email protected]>

* Changed time back to minutes It makes much more cleaner code. It's ok to not just specify %unit% in the pattern. The pattern is a template anyway. Signed-off-by: Hilbrand Bouwkamp <[email protected]> * Updated snapshot version to 2.5.8-SNAPSHOT Signed-off-by: Hilbrand Bouwkamp <[email protected]> Co-authored-by: Andrew Schofield <[email protected]>

TravisBuddy · 2020-07-28T11:00:21Z

Travis tests were successful

Hey @andrew-schofield,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

fwolter

Thanks for your contribution! Here is my review feedback.

There are some formatting issues. You can view them with mvn spotless:check -Dspotless.check.skip=false and fix them with mvn spotless:apply.

bundles/org.openhab.binding.draytonwiser/README.md

...raytonwiser/src/main/java/org/openhab/binding/draytonwiser/internal/api/DraytonWiserApi.java

...n/java/org/openhab/binding/draytonwiser/internal/discovery/DraytonWiserDiscoveryService.java

...rg/openhab/binding/draytonwiser/internal/discovery/DraytonWiserMDNSDiscoveryParticipant.java

...rc/main/java/org/openhab/binding/draytonwiser/internal/handler/DraytonWiserThingHandler.java

...raytonwiser/src/main/java/org/openhab/binding/draytonwiser/internal/handler/RoomHandler.java

...n/java/org/openhab/binding/draytonwiser/internal/discovery/DraytonWiserDiscoveryService.java

Signed-off-by: Andrew Schofield <[email protected]>

TravisBuddy · 2020-07-29T20:45:58Z

Travis tests were successful

Hey @andrew-schofield,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

- Added missing representation property to thing xml file - Changed representation property of bridge to network address because serialnumber is not know at discovery time. - Added id as representation property to controller. To find only 1 controller if the user uses a different thinguid as the discovery. - Fixed hot water thing discovery. It doesn't have a serial number and also no related to a device. - Improved the readme formatting. - And some other review comments. Signed-off-by: Hilbrand Bouwkamp <[email protected]>

TravisBuddy · 2020-08-05T09:10:02Z

Travis tests were successful

Hey @andrew-schofield,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

fwolter

LGTM

There are two approvals from maintainers, now. But @Hilbrand contributed to this PR. How do we handle this?

andrew-schofield · 2020-08-06T21:00:23Z

LGTM

There are two approvals from maintainers, now. But @Hilbrand contributed to this PR. How do we handle this?

Yeah, I would be happier if @cpmeister also approved it if we need more than one approval.

Hilbrand · 2020-08-09T15:56:31Z

I agree that my approval is not completely independent 😉 It's just @cpmeister did approve and then left 2 small comments, which have been addressed imoh. And because @cpmeister doesn't seem to be available at the moment (his last activity was july 15th) I don't think that should be blocking this being merged (given he already approved it albeit with 2 additional comments. So if you agree with me @fwolter I would suggest we merge this binding.

kaikreuzer · 2020-08-09T19:28:00Z

I agree with @Hilbrand and this PR has anyhow a looong history with a lot of reviews, so that it is really time to have it merged. Big thanks to everyone involved here!

Also-by: Hilbrand Bouwkamp <[email protected]> Signed-off-by: Andrew Schofield <[email protected]>

Also-by: Hilbrand Bouwkamp <[email protected]> Signed-off-by: Andrew Schofield <[email protected]> Signed-off-by: Daan Meijer <[email protected]>

Also-by: Hilbrand Bouwkamp <[email protected]> Signed-off-by: Andrew Schofield <[email protected]>

martinvw added new binding If someone has started to work on a binding. For a new binding PR. work in progress A PR that is not yet ready to be merged labels Jan 24, 2018

andrew-schofield force-pushed the draytonwiser branch from 8befbad to 6f8fdfa Compare January 27, 2018 22:42

andrew-schofield force-pushed the draytonwiser branch from a52af06 to 75725d1 Compare February 6, 2018 16:08

andrew-schofield force-pushed the draytonwiser branch from 9cc09f0 to c9bf0b2 Compare March 14, 2018 21:44

andrew-schofield force-pushed the draytonwiser branch from 81c7f6a to 6c10d4d Compare March 16, 2018 22:37

andrew-schofield force-pushed the draytonwiser branch from 5165469 to b6d3485 Compare April 18, 2018 09:09

andrew-schofield changed the title ~~[draytonwiser][WIP] Initial contribution~~ [draytonwiser] Initial contribution Apr 25, 2018

martinvw removed the work in progress A PR that is not yet ready to be merged label Apr 25, 2018

andrew-schofield force-pushed the draytonwiser branch 3 times, most recently from cdfd4a2 to 33c47b1 Compare June 14, 2018 21:42

triller-telekom requested changes Jul 13, 2018

View reviewed changes

andrew-schofield force-pushed the draytonwiser branch 2 times, most recently from 98363f0 to b33849f Compare August 12, 2018 20:22

andrew-schofield added 4 commits July 28, 2020 11:44

[draytonwiser] Fix bug where all items were discoverd as smart plugs

72271c1

Signed-off-by: Andrew Schofield <[email protected]>

[draytonwiser] Updated hot water and room boost to return time in min…

db9b424

…utes Signed-off-by: Andrew Schofield <[email protected]>

[draytonwiser] Fix error in readme where boost duration was given wro…

efbd3f6

…ng quantity type Signed-off-by: Andrew Schofield <[email protected]>

[draytonwiser] Remove possibility of returning a null state for boost…

565fbd7

… duration Signed-off-by: Andrew Schofield <[email protected]>

andrew-schofield force-pushed the draytonwiser branch from fe35575 to 565fbd7 Compare July 28, 2020 10:48

andrew-schofield requested a review from Hilbrand July 28, 2020 11:01

Hilbrand added this to the 2.5.8 milestone Jul 28, 2020

Hilbrand approved these changes Jul 28, 2020

View reviewed changes

fwolter requested changes Jul 29, 2020

View reviewed changes

andrew-schofield added 3 commits July 29, 2020 21:14

[draytonwiser] Fix item type of window state

9a6a1e1

Signed-off-by: Andrew Schofield <[email protected]>

[draytonwiser] Remove redundant imports

4da5349

Signed-off-by: Andrew Schofield <[email protected]>

[draytonwiser] Fix spotless warnings

8dc59bd

Signed-off-by: Andrew Schofield <[email protected]>

andrew-schofield requested a review from fwolter August 5, 2020 09:10

fwolter approved these changes Aug 6, 2020

View reviewed changes

kaikreuzer merged commit 6e32b2f into openhab:2.5.x Aug 9, 2020

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020

[draytonwiser] Drayton Wiser Binding initial contribution (openhab#3168)

63f74d5

Also-by: Hilbrand Bouwkamp <[email protected]> Signed-off-by: Andrew Schofield <[email protected]>

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020

[draytonwiser] Drayton Wiser Binding initial contribution (openhab#3168)

7b8af85

Also-by: Hilbrand Bouwkamp <[email protected]> Signed-off-by: Andrew Schofield <[email protected]>

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020

[draytonwiser] Drayton Wiser Binding initial contribution (openhab#3168)

82a499b

Also-by: Hilbrand Bouwkamp <[email protected]> Signed-off-by: Andrew Schofield <[email protected]>

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020

[draytonwiser] Drayton Wiser Binding initial contribution (openhab#3168)

0f2b874

Also-by: Hilbrand Bouwkamp <[email protected]> Signed-off-by: Andrew Schofield <[email protected]>

CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020

[draytonwiser] Drayton Wiser Binding initial contribution (openhab#3168)

a8bdac9

Also-by: Hilbrand Bouwkamp <[email protected]> Signed-off-by: Andrew Schofield <[email protected]>

markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020

[draytonwiser] Drayton Wiser Binding initial contribution (openhab#3168)

eeb70b8

Also-by: Hilbrand Bouwkamp <[email protected]> Signed-off-by: Andrew Schofield <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[draytonwiser] Drayton Wiser Binding initial contribution #3168

[draytonwiser] Drayton Wiser Binding initial contribution #3168

andrew-schofield commented Jan 24, 2018 •

edited

Loading

openhab-bot commented Jan 24, 2018

andrew-schofield commented Jan 31, 2018

openhab-bot commented Feb 1, 2018

openhab-bot commented Feb 1, 2018

openhab-bot commented Mar 15, 2018

andrew-schofield commented Apr 5, 2018

andrew-schofield commented Apr 25, 2018

andrew-schofield commented Jun 14, 2018

openhab-bot commented Jun 24, 2018

triller-telekom left a comment •

edited

Loading

triller-telekom commented Jul 23, 2018

andrew-schofield commented Jul 29, 2018 •

edited

Loading

triller-telekom commented Jul 31, 2018

andrew-schofield commented Aug 3, 2018

triller-telekom commented Aug 6, 2018

andrew-schofield commented Aug 12, 2018

TravisBuddy commented Jul 28, 2020

fwolter left a comment

TravisBuddy commented Jul 29, 2020

TravisBuddy commented Aug 5, 2020

fwolter left a comment

andrew-schofield commented Aug 6, 2020

Hilbrand commented Aug 9, 2020

kaikreuzer commented Aug 9, 2020

[draytonwiser] Drayton Wiser Binding initial contribution #3168

[draytonwiser] Drayton Wiser Binding initial contribution #3168

Conversation

andrew-schofield commented Jan 24, 2018 • edited Loading

openhab-bot commented Jan 24, 2018

andrew-schofield commented Jan 31, 2018

openhab-bot commented Feb 1, 2018

openhab-bot commented Feb 1, 2018

openhab-bot commented Mar 15, 2018

andrew-schofield commented Apr 5, 2018

andrew-schofield commented Apr 25, 2018

andrew-schofield commented Jun 14, 2018

openhab-bot commented Jun 24, 2018

triller-telekom left a comment • edited Loading

Choose a reason for hiding this comment

triller-telekom commented Jul 23, 2018

andrew-schofield commented Jul 29, 2018 • edited Loading

triller-telekom commented Jul 31, 2018

andrew-schofield commented Aug 3, 2018

triller-telekom commented Aug 6, 2018

andrew-schofield commented Aug 12, 2018

TravisBuddy commented Jul 28, 2020

Travis tests were successful

fwolter left a comment

Choose a reason for hiding this comment

TravisBuddy commented Jul 29, 2020

Travis tests were successful

TravisBuddy commented Aug 5, 2020

Travis tests were successful

fwolter left a comment

Choose a reason for hiding this comment

andrew-schofield commented Aug 6, 2020

Hilbrand commented Aug 9, 2020

kaikreuzer commented Aug 9, 2020

andrew-schofield commented Jan 24, 2018 •

edited

Loading

triller-telekom left a comment •

edited

Loading

andrew-schofield commented Jul 29, 2018 •

edited

Loading