Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kodi] Updated/extended the readme #1904

Merged
merged 5 commits into from
Feb 18, 2017
Merged

[Kodi] Updated/extended the readme #1904

merged 5 commits into from
Feb 18, 2017

Conversation

CWempe
Copy link

@CWempe CWempe commented Feb 16, 2017 •
edited
Loading

lower case did not work for me

2017-02-16 22:21:50.978 [WARN ] [.classic.internal.servlet.CmdServlet] - Received unknown command 'pause' for item 'HTPC_control'

Signed-off-by: Christoph Wempe [email protected] (github: CWempe)

@CWempe
changed control values to upper case
cc391aa 
lower case did not work for me
> 2017-02-16 22:21:50.978 [WARN ] [.classic.internal.servlet.CmdServlet] - Received unknown command 'pause' for item 'HTPC_control'
@mention-bot
Copy link

@CWempe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pail23 and @gersilex to be potential reviewers.

kaikreuzer
kaikreuzer requested changes Feb 17, 2017
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign your commits - note that this is also possible through the Github editor by adding the "Signed-off-by ..." line in the comment field.

addons/binding/org.openhab.binding.kodi/README.md Outdated
| mediatype | String | The media type of the current file. e.g. song or movie |

## Item Configuration
demo.items
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add empty lines before and after here, see https://www.eclipse.org/smarthome/documentation/development/bindings/docs.html

addons/binding/org.openhab.binding.kodi/README.md Outdated
```

## Sitemap Configuration
demo.sitemap
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

CWempe
CWempe commented Feb 18, 2017
View reviewed changes
Copy link
Author

@CWempe CWempe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Christoph Wempe [email protected] (github: CWempe)

@CWempe
add empty lines before and after headlines and code
531ed97 
Signed-off-by: Christoph Wempe <[email protected]> (github: CWempe)
@CWempe
Copy link
Author

CWempe commented Feb 18, 2017

I got two questions.

  1. Is my "Signed-off-by" at the right place?
    I cannot find a way to edit the original commit message.
    I can only edit the PR message, add a comment or create a new commit.

  2. I don't want my private mail address to be displayed here so I created a new one. Name and github hanlde are correct.
    Do I have to use the address I am using for my github account?
    It is not clear in the guide line. (http://docs.openhab.org/developers/contributing/contributing#sign-your-work)
    Buit it looks like my "Signed-off-by" is not accepted by the eclipse "ip-validation" process in another PR.

@kaikreuzer
Copy link
Member

Is my "Signed-off-by" at the right place?

Yes, that's fine, thanks.

Do I have to use the address I am using for my github account?

No, any address under which you are reachable will do.

my "Signed-off-by" is not accepted by the eclipse "ip-validation" process in another PR.

For ESH contributions, you will have to use the e-mail address that you also use for your Eclipse account (under which you have signed the ECA).

kaikreuzer
kaikreuzer approved these changes Feb 18, 2017
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit 457c9df into openhab:master Feb 18, 2017
@CWempe CWempe deleted the patch-2 branch February 18, 2017 18:28
fharni pushed a commit to fharni/openhab2-addons that referenced this pull request Feb 19, 2017
@CWempe @fharni
changed control values to upper case (openhab#1904)
5dee9f9 
* changed control values to upper case

lower case did not work for me
> 2017-02-16 22:21:50.978 [WARN ] [.classic.internal.servlet.CmdServlet] - Received unknown command 'pause' for item 'HTPC_control'

* changed FFWARD to FASTFORWARD

according to source code

* little cleanup to highlight item values

* added examples for items and sitemap configuration

* add empty lines before and after headlines and code

Signed-off-by: Christoph Wempe <[email protected]> (github: CWempe)
jarlebh pushed a commit to jarlebh/openhab2-addons that referenced this pull request Mar 4, 2017
@CWempe @jarlebh
changed control values to upper case (openhab#1904)
5b68c88 
* changed control values to upper case

lower case did not work for me
> 2017-02-16 22:21:50.978 [WARN ] [.classic.internal.servlet.CmdServlet] - Received unknown command 'pause' for item 'HTPC_control'

* changed FFWARD to FASTFORWARD

according to source code

* little cleanup to highlight item values

* added examples for items and sitemap configuration

* add empty lines before and after headlines and code

Signed-off-by: Christoph Wempe <[email protected]> (github: CWempe)
cweitkamp pushed a commit to cweitkamp/openhab-addons that referenced this pull request Mar 26, 2017
@CWempe @cweitkamp
changed control values to upper case (openhab#1904)
247aafc 
* changed control values to upper case

lower case did not work for me
> 2017-02-16 22:21:50.978 [WARN ] [.classic.internal.servlet.CmdServlet] - Received unknown command 'pause' for item 'HTPC_control'

* changed FFWARD to FASTFORWARD

according to source code

* little cleanup to highlight item values

* added examples for items and sitemap configuration

* add empty lines before and after headlines and code

Signed-off-by: Christoph Wempe <[email protected]> (github: CWempe)
tratho pushed a commit to tratho/openhab2-addons that referenced this pull request May 5, 2017
@CWempe @tratho
changed control values to upper case (openhab#1904)
71747b5 
* changed control values to upper case

lower case did not work for me
> 2017-02-16 22:21:50.978 [WARN ] [.classic.internal.servlet.CmdServlet] - Received unknown command 'pause' for item 'HTPC_control'

* changed FFWARD to FASTFORWARD

according to source code

* little cleanup to highlight item values

* added examples for items and sitemap configuration

* add empty lines before and after headlines and code

Signed-off-by: Christoph Wempe <[email protected]> (github: CWempe)
@martinvw martinvw changed the title changed control values to upper case [Kodi] Updated/extended the readme Jun 25, 2017
@martinvw martinvw added the enhancement An enhancement or new feature for an existing add-on label Jun 25, 2017
@martinvw martinvw added this to the 2.1 milestone Jun 25, 2017
@martinvw martinvw removed the enhancement An enhancement or new feature for an existing add-on label Jun 25, 2017
Markinus pushed a commit to Markinus/openhab2-addons that referenced this pull request Jul 2, 2017
@CWempe @Markinus
changed control values to upper case (openhab#1904)
f80077e 
* changed control values to upper case

lower case did not work for me
> 2017-02-16 22:21:50.978 [WARN ] [.classic.internal.servlet.CmdServlet] - Received unknown command 'pause' for item 'HTPC_control'

* changed FFWARD to FASTFORWARD

according to source code

* little cleanup to highlight item values

* added examples for items and sitemap configuration

* add empty lines before and after headlines and code

Signed-off-by: Christoph Wempe <[email protected]> (github: CWempe)
aogorek pushed a commit to aogorek/openhab2-addons that referenced this pull request Jul 5, 2017
@CWempe
changed control values to upper case (openhab#1904)
8d8eb64 
* changed control values to upper case

lower case did not work for me
> 2017-02-16 22:21:50.978 [WARN ] [.classic.internal.servlet.CmdServlet] - Received unknown command 'pause' for item 'HTPC_control'

* changed FFWARD to FASTFORWARD

according to source code

* little cleanup to highlight item values

* added examples for items and sitemap configuration

* add empty lines before and after headlines and code

Signed-off-by: Christoph Wempe <[email protected]> (github: CWempe)
Markinus pushed a commit to Markinus/openhab2-addons that referenced this pull request Sep 8, 2017
@CWempe @Markinus
changed control values to upper case (openhab#1904)
bf73c77 
* changed control values to upper case

lower case did not work for me
> 2017-02-16 22:21:50.978 [WARN ] [.classic.internal.servlet.CmdServlet] - Received unknown command 'pause' for item 'HTPC_control'

* changed FFWARD to FASTFORWARD

according to source code

* little cleanup to highlight item values

* added examples for items and sitemap configuration

* add empty lines before and after headlines and code

Signed-off-by: Christoph Wempe <[email protected]> (github: CWempe)
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Aug 12, 2023
@ccutrer
add mireds to units of measurement (openhab#1904)
f3ffc3b 
* add mireds to units of measurement

Signed-off-by: Cody Cutrer <[email protected]>

* use manual link instead of markdown footnote

Signed-off-by: Cody Cutrer <[email protected]>

Signed-off-by: Cody Cutrer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@CWempe @mention-bot @kaikreuzer @martinvw