-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[onkyo] add Album Art URL channel #1889
Conversation
To be used for UI's that don't support image Itemtype yet Signed-off-by: Marcel Verpaalen <[email protected]>
@marcelrv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pail23, @paulianttila and @vbier to be potential reviewers. |
LGTM except one thing: refresh command is not handled by the new channel. |
Indeed, I was doubting about it, as it would possibly trigger twice the data pull (due to the 2 types of album art channels). |
Signed-off-by: Marcel Verpaalen <[email protected]>
@marcelrv : you should first check if the channel is linked in handleCommand. If not, do nothing. That way, no risk to request data for mothing. |
@lolodomo how you mean, does the fact that the channel trigger a REFRESH in handlecommand not automatically mean that it is linked? |
Note that if no client is observing the image item, the data pull is still for nothing, even if the channel is linked. |
Refresh command is sent to all channels, either linked to an item or not. |
Really? No, it should imho only be sent to linked channels. |
I have a doubt now. That is to be checked. |
I did small test, and as far as I can see it only refreshed linked channels |
So in this case, LGTM |
* [onkyo] bring back Album Art URL channel To be used for UI's that don't support image Itemtype yet Signed-off-by: Marcel Verpaalen <[email protected]>
* [onkyo] bring back Album Art URL channel To be used for UI's that don't support image Itemtype yet Signed-off-by: Marcel Verpaalen <[email protected]>
* [onkyo] bring back Album Art URL channel To be used for UI's that don't support image Itemtype yet Signed-off-by: Marcel Verpaalen <[email protected]>
* [onkyo] bring back Album Art URL channel To be used for UI's that don't support image Itemtype yet Signed-off-by: Marcel Verpaalen <[email protected]>
* [onkyo] bring back Album Art URL channel To be used for UI's that don't support image Itemtype yet Signed-off-by: Marcel Verpaalen <[email protected]>
* [onkyo] bring back Album Art URL channel To be used for UI's that don't support image Itemtype yet Signed-off-by: Marcel Verpaalen <[email protected]>
* [onkyo] bring back Album Art URL channel To be used for UI's that don't support image Itemtype yet Signed-off-by: Marcel Verpaalen <[email protected]>
Signed-off-by: Jerome Luckenbach <[email protected]> Signed-off-by: Jerome Luckenbach <[email protected]>
This channel got lost in the previous onkyo album art PR
To be used for UI's that don't support image Itemtype yet (basic/classic)