Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onkyo] add Album Art URL channel #1889

Merged
merged 2 commits into from
Feb 16, 2017
Merged

Conversation

marcelrv
Copy link
Contributor

This channel got lost in the previous onkyo album art PR
To be used for UI's that don't support image Itemtype yet (basic/classic)

To be used for UI's that don't support image Itemtype yet

Signed-off-by: Marcel Verpaalen <[email protected]>
@mention-bot
Copy link

@marcelrv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pail23, @paulianttila and @vbier to be potential reviewers.

@lolodomo
Copy link
Contributor

LGTM except one thing: refresh command is not handled by the new channel.

@marcelrv
Copy link
Contributor Author

Indeed, I was doubting about it, as it would possibly trigger twice the data pull (due to the 2 types of album art channels).
Anyway, indeed if one would only use basic/classic UI, the other channel would not be included and the refresh would not be triggered

@lolodomo
Copy link
Contributor

@marcelrv : you should first check if the channel is linked in handleCommand. If not, do nothing. That way, no risk to request data for mothing.

@marcelrv
Copy link
Contributor Author

@lolodomo how you mean, does the fact that the channel trigger a REFRESH in handlecommand not automatically mean that it is linked?

@watou
Copy link

watou commented Feb 14, 2017

you should first check if the channel is linked in handleCommand. If not, do nothing. That way, no risk to request data for nothing.

Note that if no client is observing the image item, the data pull is still for nothing, even if the channel is linked.

@lolodomo
Copy link
Contributor

Refresh command is sent to all channels, either linked to an item or not.

@kaikreuzer
Copy link
Member

Really? No, it should imho only be sent to linked channels.

@lolodomo
Copy link
Contributor

I have a doubt now. That is to be checked.

@marcelrv
Copy link
Contributor Author

I did small test, and as far as I can see it only refreshed linked channels

@lolodomo
Copy link
Contributor

So in this case, LGTM

@kaikreuzer kaikreuzer merged commit 3687810 into openhab:master Feb 16, 2017
@marcelrv marcelrv deleted the onkyo-url branch February 16, 2017 10:06
fharni pushed a commit to fharni/openhab2-addons that referenced this pull request Feb 19, 2017
* [onkyo] bring back Album Art URL channel
To be used for UI's that don't support image Itemtype yet

Signed-off-by: Marcel Verpaalen <[email protected]>
jarlebh pushed a commit to jarlebh/openhab2-addons that referenced this pull request Mar 4, 2017
* [onkyo] bring back Album Art URL channel
To be used for UI's that don't support image Itemtype yet

Signed-off-by: Marcel Verpaalen <[email protected]>
cweitkamp pushed a commit to cweitkamp/openhab-addons that referenced this pull request Mar 26, 2017
* [onkyo] bring back Album Art URL channel
To be used for UI's that don't support image Itemtype yet

Signed-off-by: Marcel Verpaalen <[email protected]>
tratho pushed a commit to tratho/openhab2-addons that referenced this pull request May 5, 2017
* [onkyo] bring back Album Art URL channel
To be used for UI's that don't support image Itemtype yet

Signed-off-by: Marcel Verpaalen <[email protected]>
@martinvw martinvw changed the title [onkyo] bring back Album Art URL channel [onkyo] add Album Art URL channel Jun 25, 2017
@martinvw martinvw added the enhancement An enhancement or new feature for an existing add-on label Jun 25, 2017
@martinvw martinvw added this to the 2.1 milestone Jun 25, 2017
Markinus pushed a commit to Markinus/openhab2-addons that referenced this pull request Jul 2, 2017
* [onkyo] bring back Album Art URL channel
To be used for UI's that don't support image Itemtype yet

Signed-off-by: Marcel Verpaalen <[email protected]>
aogorek pushed a commit to aogorek/openhab2-addons that referenced this pull request Jul 5, 2017
* [onkyo] bring back Album Art URL channel
To be used for UI's that don't support image Itemtype yet

Signed-off-by: Marcel Verpaalen <[email protected]>
Markinus pushed a commit to Markinus/openhab2-addons that referenced this pull request Sep 8, 2017
* [onkyo] bring back Album Art URL channel
To be used for UI's that don't support image Itemtype yet

Signed-off-by: Marcel Verpaalen <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Aug 12, 2023
Signed-off-by: Jerome Luckenbach <[email protected]>

Signed-off-by: Jerome Luckenbach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants