[HDanywhere] Add support for new line of matrices & updated the documentation #1883

kgoderis · 2017-02-12T12:37:20Z

Signed-off-by: Karel Goderis [email protected]

mention-bot · 2017-02-12T12:37:21Z

@kgoderis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kaikreuzer and @svilenvul to be potential reviewers.

watou · 2017-02-12T13:07:44Z

addons/binding/org.openhab.binding.hdanywhere/README.md

+
+This binding integrates with [HDanywhere](http://www.hdanywhere.co.uk) HDMI matrices. 
+
+HDanywhereis a manufacturer of multiroom/distributed audio/video equipment. This binding supports their V3 of the Multiroom+ HDMI matrix running firmware V1.2(20131222), as well as the newer MHUB series of matrices. These matrices support the highest HD resolutions, including 1080p 3D & 4K, use a single Cat5e/6/7 wiring structure with reliable performance up to 100m, have IR passback to allow you to select and control what you watch from every room and are fully compatible with universal remote controls


HDanywhere is

watou · 2017-02-12T13:08:09Z

addons/binding/org.openhab.binding.hdanywhere/README.md

+
+HDanywhereis a manufacturer of multiroom/distributed audio/video equipment. This binding supports their V3 of the Multiroom+ HDMI matrix running firmware V1.2(20131222), as well as the newer MHUB series of matrices. These matrices support the highest HD resolutions, including 1080p 3D & 4K, use a single Cat5e/6/7 wiring structure with reliable performance up to 100m, have IR passback to allow you to select and control what you watch from every room and are fully compatible with universal remote controls
+
+The matrixes can be controlled by either UDP/IP and/or Serial connections, but due to the lack of feedback on the actual state of the HDMI matrix when using those methods, this binding operates by controlling the built-in webserver of the matrix.


watou · 2017-02-12T13:08:33Z

addons/binding/org.openhab.binding.hdanywhere/README.md

+
+## Discovery
+
+The binding does not support a discovery feature


watou · 2017-02-12T13:08:52Z

addons/binding/org.openhab.binding.hdanywhere/README.md

+
+## Thing Configuration
+
+Each thing requires the IP address of the matrix, and the interval in between status updates that are fetched from the matrix. Additionally, the *multiroomplus* has an additional required parameter 'ports' to specify the number of physical ports (e.g. 4x4, 8x8,...) of the matrix


watou · 2017-02-12T13:09:31Z

addons/binding/org.openhab.binding.hdanywhere/README.md

+| port8           |  Number       | The number of the input port that is connected to the output port 8 |
+
+
+## Binding Configuration


Duplicate of existing section above.

watou · 2017-02-12T13:11:49Z

addons/binding/org.openhab.binding.hdanywhere/OSGI-INF/HDanywhereHandlerFactory.xml

   <implementation class="org.openhab.binding.hdanywhere.internal.HDanywhereHandlerFactory"/>
-
+   <reference bind="setItemChannelLinkRegistry" cardinality="1..1" interface="org.eclipse.smarthome.core.thing.link.ItemChannelLinkRegistry" name="ItemChannelLinkRegistry" policy="static" unbind="unsetItemChannelLinkRegistry"/>


So bindings are allowed to use the ItemChannelLinkRegistry now?

@watou ;-) I see no reason why they would not be allowed to do so, do you?

I can't say that I know enough to have a fully informed opinion, but with that huge caveat, no I don't know of a reason! ;-)

No, it is not, see here.
I guess Karel wants to work around the fact that eclipse-archived/smarthome#595 isn't yet implemented.

Same reason it's now used in KNX 2.0 binding?

kgoderis · 2017-02-13T16:28:27Z

here the idea is to overrule whatever is set by means of the AutoUpdate binding, eg the binding will report back the actual state of a Channel, and does not need the runtime to update the Item

…

On 13 Feb 2017, at 10:21, John Cocula ***@***.***> wrote: @watou commented on this pull request. In addons/binding/org.openhab.binding.hdanywhere/OSGI-INF/HDanywhereHandlerFactory.xml: > <implementation class="org.openhab.binding.hdanywhere.internal.HDanywhereHandlerFactory"/> - + <reference bind="setItemChannelLinkRegistry" cardinality="1..1" interface="org.eclipse.smarthome.core.thing.link.ItemChannelLinkRegistry" name="ItemChannelLinkRegistry" policy="static" unbind="unsetItemChannelLinkRegistry"/> Same reason it's now used in KNX 2.0 binding? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

kgoderis · 2017-02-13T16:32:08Z

The list of bundles reads as list of suggestive bundles to use, and not as an exhaustive list, at least to me it does @kaikreuzer Shall we proceed with the workaround until the disable feature is provided?

…

Sent from my iPhone

On 13 Feb 2017, at 10:09, Kai Kreuzer ***@***.***> wrote: @kaikreuzer commented on this pull request. In addons/binding/org.openhab.binding.hdanywhere/OSGI-INF/HDanywhereHandlerFactory.xml: > <implementation class="org.openhab.binding.hdanywhere.internal.HDanywhereHandlerFactory"/> - + <reference bind="setItemChannelLinkRegistry" cardinality="1..1" interface="org.eclipse.smarthome.core.thing.link.ItemChannelLinkRegistry" name="ItemChannelLinkRegistry" policy="static" unbind="unsetItemChannelLinkRegistry"/> No, it is not, see here. I guess Karel wants to work around the fact that eclipse-archived/smarthome#595 isn't yet implemented. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

kaikreuzer · 2017-02-13T17:15:18Z

@kaikreuzer Shall we proceed with the workaround until the disable feature is provided?

No, I don't think so. What is the issue with having the state update event? Your binding can still send the "final" state itself as soon as it can provide it? That's how it works for almost all bindings.

kgoderis · 2017-02-13T17:51:30Z

The fact that you have 2 updates; and when it does not update it would indicate that there is some kind of problem with the device, instead of going unnoticed.

…

On 13 Feb 2017, at 18:15, Kai Kreuzer ***@***.***> wrote: @kaikreuzer Shall we proceed with the workaround until the disable feature is provided? No, I don't think so. What is the issue with having the state update event? Your binding can still send the "final" state itself as soon as it can provide it? That's how it works for almost all bindings. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

kaikreuzer · 2017-02-13T18:05:47Z

That's absolutely fine and just the way it is designed. Consider the first update to be the "optimistic, but quick guess" and the second as the "definitive, but slow update".
Problems with devices should be anyhow identified by the binding and reported through the Thing status.

kgoderis · 2017-02-13T18:19:00Z

@kaikreuzer done with the small fixes + auto-update revert.

kaikreuzer

Thanks, just some very small remarks.

kaikreuzer · 2017-02-14T14:38:35Z

...inding.hdanywhere/src/main/java/org/openhab/binding/hdanywhere/handler/Mhub4K431Handler.java

+                    String response = HttpUtil.executeUrl(httpMethod, url, httpHeaders, stream,
+                            "application/x-www-form-urlencoded; charset=UTF-8", timeout);
+                } catch (IOException e) {
+                    logger.error("Communication with device failed: {}", e);


could you set the ThingStatus to OFFLINE with an according message and reduce the logging to debug?

kaikreuzer · 2017-02-14T14:39:21Z

addons/binding/org.openhab.binding.hdanywhere/META-INF/MANIFEST.MF

 org.apache.commons.lang,
 org.eclipse.smarthome.config.core,
+ org.eclipse.smarthome.core.autoupdate,


I guess this line can be removed again

kaikreuzer · 2017-02-14T14:39:24Z

addons/binding/org.openhab.binding.hdanywhere/META-INF/MANIFEST.MF

 org.eclipse.smarthome.core.library.types,
 org.eclipse.smarthome.core.thing,
 org.eclipse.smarthome.core.thing.binding,
+ org.eclipse.smarthome.core.thing.link,


Signed-off-by: Karel Goderis <[email protected]>

kgoderis · 2017-02-14T17:00:54Z

@kaikreuzer done.

kaikreuzer

thanks

…b#1883) Signed-off-by: Karel Goderis <[email protected]>

* Fix wrong Location_Indoor_Floor_SecondFloor translation * Remove redundant whitespace chars Signed-off-by: Wouter Born <[email protected]>

watou requested changes Feb 12, 2017

View reviewed changes

kgoderis force-pushed the hdanywhere-extend branch from ec8307a to 735b416 Compare February 13, 2017 18:17

kaikreuzer reviewed Feb 14, 2017

View reviewed changes

HDanywhere : Add support for new line of matrices + readme.MD

de0451b

Signed-off-by: Karel Goderis <[email protected]>

kgoderis force-pushed the hdanywhere-extend branch from 735b416 to de0451b Compare February 14, 2017 17:00

kaikreuzer approved these changes Feb 15, 2017

View reviewed changes

kaikreuzer merged commit cacd3f6 into openhab:master Feb 15, 2017

fharni pushed a commit to fharni/openhab2-addons that referenced this pull request Feb 19, 2017

HDanywhere : Add support for new line of matrices + readme.MD (openha…

95a2b47

…b#1883) Signed-off-by: Karel Goderis <[email protected]>

jarlebh pushed a commit to jarlebh/openhab2-addons that referenced this pull request Mar 4, 2017

HDanywhere : Add support for new line of matrices + readme.MD (openha…

404aa55

…b#1883) Signed-off-by: Karel Goderis <[email protected]>

cweitkamp pushed a commit to cweitkamp/openhab-addons that referenced this pull request Mar 26, 2017

HDanywhere : Add support for new line of matrices + readme.MD (openha…

0165642

…b#1883) Signed-off-by: Karel Goderis <[email protected]>

kgoderis deleted the hdanywhere-extend branch April 17, 2017 15:05

tratho pushed a commit to tratho/openhab2-addons that referenced this pull request May 5, 2017

HDanywhere : Add support for new line of matrices + readme.MD (openha…

ee9cf7b

…b#1883) Signed-off-by: Karel Goderis <[email protected]>

martinvw changed the title ~~HDanywhere : Add support for new line of matrices + readme.MD~~ [HDanywhere] Add support for new line of matrices & updated the documentation Jun 25, 2017

martinvw added the enhancement An enhancement or new feature for an existing add-on label Jun 25, 2017

martinvw added this to the 2.1 milestone Jun 25, 2017

Markinus pushed a commit to Markinus/openhab2-addons that referenced this pull request Jul 2, 2017

HDanywhere : Add support for new line of matrices + readme.MD (openha…

b0d5fac

…b#1883) Signed-off-by: Karel Goderis <[email protected]>

aogorek pushed a commit to aogorek/openhab2-addons that referenced this pull request Jul 5, 2017

HDanywhere : Add support for new line of matrices + readme.MD (openha…

b93a5ba

…b#1883) Signed-off-by: Karel Goderis <[email protected]>

Markinus pushed a commit to Markinus/openhab2-addons that referenced this pull request Sep 8, 2017

HDanywhere : Add support for new line of matrices + readme.MD (openha…

39ed71e

…b#1883) Signed-off-by: Karel Goderis <[email protected]>

Flole998 pushed a commit to Flole998/openhab-addons that referenced this pull request Dec 30, 2021

Improve tags_nl.properties (openhab#1883)

6e0a5d0

* Fix wrong Location_Indoor_Floor_SecondFloor translation * Remove redundant whitespace chars Signed-off-by: Wouter Born <[email protected]>

markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Aug 12, 2023

add logo for easee binding (openhab#1883)

79428e5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HDanywhere] Add support for new line of matrices & updated the documentation #1883

[HDanywhere] Add support for new line of matrices & updated the documentation #1883

kgoderis commented Feb 12, 2017

mention-bot commented Feb 12, 2017

watou Feb 12, 2017

watou Feb 12, 2017

watou Feb 12, 2017

watou Feb 12, 2017

watou Feb 12, 2017

watou Feb 12, 2017

kgoderis Feb 12, 2017

watou Feb 12, 2017

kaikreuzer Feb 13, 2017

watou Feb 13, 2017

kgoderis commented Feb 13, 2017 via email

kgoderis commented Feb 13, 2017 via email

kaikreuzer commented Feb 13, 2017

kgoderis commented Feb 13, 2017 via email

kaikreuzer commented Feb 13, 2017

kgoderis commented Feb 13, 2017

kaikreuzer left a comment

kaikreuzer Feb 14, 2017

kaikreuzer Feb 14, 2017

kaikreuzer Feb 14, 2017

kgoderis commented Feb 14, 2017

kaikreuzer left a comment


		This binding integrates with [HDanywhere](http://www.hdanywhere.co.uk) HDMI matrices.

		HDanywhereis a manufacturer of multiroom/distributed audio/video equipment. This binding supports their V3 of the Multiroom+ HDMI matrix running firmware V1.2(20131222), as well as the newer MHUB series of matrices. These matrices support the highest HD resolutions, including 1080p 3D & 4K, use a single Cat5e/6/7 wiring structure with reliable performance up to 100m, have IR passback to allow you to select and control what you watch from every room and are fully compatible with universal remote controls


		HDanywhereis a manufacturer of multiroom/distributed audio/video equipment. This binding supports their V3 of the Multiroom+ HDMI matrix running firmware V1.2(20131222), as well as the newer MHUB series of matrices. These matrices support the highest HD resolutions, including 1080p 3D & 4K, use a single Cat5e/6/7 wiring structure with reliable performance up to 100m, have IR passback to allow you to select and control what you watch from every room and are fully compatible with universal remote controls

		The matrixes can be controlled by either UDP/IP and/or Serial connections, but due to the lack of feedback on the actual state of the HDMI matrix when using those methods, this binding operates by controlling the built-in webserver of the matrix.


		## Discovery

		The binding does not support a discovery feature


		## Thing Configuration

		Each thing requires the IP address of the matrix, and the interval in between status updates that are fetched from the matrix. Additionally, the multiroomplus has an additional required parameter 'ports' to specify the number of physical ports (e.g. 4x4, 8x8,...) of the matrix

		\| port8 \| Number \| The number of the input port that is connected to the output port 8 \|


		## Binding Configuration

		<implementation class="org.openhab.binding.hdanywhere.internal.HDanywhereHandlerFactory"/>

		<reference bind="setItemChannelLinkRegistry" cardinality="1..1" interface="org.eclipse.smarthome.core.thing.link.ItemChannelLinkRegistry" name="ItemChannelLinkRegistry" policy="static" unbind="unsetItemChannelLinkRegistry"/>

[HDanywhere] Add support for new line of matrices & updated the documentation #1883

[HDanywhere] Add support for new line of matrices & updated the documentation #1883

Conversation

kgoderis commented Feb 12, 2017

mention-bot commented Feb 12, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kgoderis commented Feb 13, 2017 via email

kgoderis commented Feb 13, 2017 via email

kaikreuzer commented Feb 13, 2017

kgoderis commented Feb 13, 2017 via email

kaikreuzer commented Feb 13, 2017

kgoderis commented Feb 13, 2017

kaikreuzer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kgoderis commented Feb 14, 2017

kaikreuzer left a comment

Choose a reason for hiding this comment