Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homematic: Optimized parameters and initialization #1858

Merged
merged 12 commits into from
Feb 12, 2017
Merged

Homematic: Optimized parameters and initialization #1858

merged 12 commits into from
Feb 12, 2017

Conversation

gerrieg
Copy link
Contributor

@gerrieg gerrieg commented Feb 7, 2017

No description provided.

@mention-bot
Copy link

@gerrieg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kaikreuzer to be a potential reviewer.

@gerrieg
Copy link
Contributor Author

gerrieg commented Feb 8, 2017

The scheduler.execute in the bridge and thing initialization does not fix the warning 'Initializing handler for thing ... takes more than 5000ms.'
How can i avoid this message? Initializing a thing could take longer than 5000ms.

@kaikreuzer
Copy link
Member

How can i avoid this message? Initializing a thing could take longer than 5000ms.

The initialize() method has to return quickly - if this takes longer then 5s, you will see the warning.
But as I can see in your code, you seem to do the right thing: Schedule the long-running parts in a job that can run asynchronous then. Setting the ThingStatus to ONLINE/OFFLINE more than 5 seconds later is fully ok.

So can you confirm that your initialize() returns quickly? If this is the case and you nonetheless see the warning, we will have to analyse more closely why this happens.

@kaikreuzer
Copy link
Member

There seems to be some problem in the framework, see eclipse-archived/smarthome#2986

@gerrieg
Copy link
Contributor Author

gerrieg commented Feb 9, 2017

It seems to be my fault. I built the homematic jar, copied the file into build 779. But it does not use the new jar file but the old one.

I replaced the homematic jar file in the kar file and in the folder userdata/kar/openhab-addons-2.1.0-SNAPSHOT/org/openhab/binding/org.openhab.binding.homematic/2.1.0-SNAPSHOT/org.openhab.binding.homematic-2.1.0-SNAPSHOT.jar but it still uses the old jar!?
I verified the jar with a java decompiler, it's the new one. I also deleted the userdata/cache/org.eclipse.osgi folder.

How can i install a new jar? Is there a cache somewhere?

@kaikreuzer
Copy link
Member

Could you rebase this branch on the latest master, so that Github diff does not show the license header changes anymore?

@gerrieg
Copy link
Contributor Author

gerrieg commented Feb 11, 2017

rebase done

@@ -1,176 +0,0 @@
# Zoneminder Binding
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a good idea to delete readmes from other bindings :-)

@gerrieg
Copy link
Contributor Author

gerrieg commented Feb 12, 2017

Ups :-) sorry, i had a pull conflict and forgot to revert the commit

@kaikreuzer kaikreuzer merged commit 79cce37 into openhab:master Feb 12, 2017
fharni pushed a commit to fharni/openhab2-addons that referenced this pull request Feb 19, 2017
* Optimized parameters and initialization

Signed-off-by: Gerhard Riegler <[email protected]>
jarlebh pushed a commit to jarlebh/openhab2-addons that referenced this pull request Mar 4, 2017
* Optimized parameters and initialization

Signed-off-by: Gerhard Riegler <[email protected]>
cweitkamp pushed a commit to cweitkamp/openhab-addons that referenced this pull request Mar 26, 2017
* Optimized parameters and initialization

Signed-off-by: Gerhard Riegler <[email protected]>
tratho pushed a commit to tratho/openhab2-addons that referenced this pull request May 5, 2017
* Optimized parameters and initialization

Signed-off-by: Gerhard Riegler <[email protected]>
@martinvw martinvw modified the milestone: 2.1 Jun 25, 2017
Markinus pushed a commit to Markinus/openhab2-addons that referenced this pull request Jul 2, 2017
* Optimized parameters and initialization

Signed-off-by: Gerhard Riegler <[email protected]>
aogorek pushed a commit to aogorek/openhab2-addons that referenced this pull request Jul 5, 2017
* Optimized parameters and initialization

Signed-off-by: Gerhard Riegler <[email protected]>
Markinus pushed a commit to Markinus/openhab2-addons that referenced this pull request Sep 8, 2017
* Optimized parameters and initialization

Signed-off-by: Gerhard Riegler <[email protected]>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/cant-set-value-for-datapoint-neqxxxxxxx-1-next-transmission/38041/1

Flole998 pushed a commit to Flole998/openhab-addons that referenced this pull request Dec 30, 2021
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants