MAX! Fix initiation issue #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaikreuzer
reviewed
Nov 27, 2016
| @@ -555,6 +556,22 @@ private void setProperties(Device device) { | |||
| * | |||
| * @param device | |||
| */ | |||
| /* (non-Javadoc) | |||
There was a problem hiding this comment.
this second JavaDoc seems superfluous.
There was a problem hiding this comment.
seems I paste it back on the wrong place. This is for the next function
kaikreuzer
reviewed
Nov 27, 2016
| public void bridgeStatusChanged(ThingStatusInfo bridgeStatusInfo) { | ||
| logger.debug("Bridge Status updated to {} for device: {}", bridgeStatusInfo.getStatus().toString(), | ||
| getThing().getUID().toString()); | ||
| getMaxCubeBridgeHandler(); |
There was a problem hiding this comment.
Is this line necessary? The handler should always be there and still be the same as during initialize() is called.
There was a problem hiding this comment.
fair. I removed it
Signed-off-by: Marcel Verpaalen <[email protected]>
|
thx! |
Jamstah
pushed a commit
to Jamstah/openhab-addons
that referenced
this pull request
Dec 12, 2016
* MAX! Fix initiation issue Signed-off-by: Marcel Verpaalen <[email protected]>
fharni
pushed a commit
to fharni/openhab2-addons
that referenced
this pull request
Feb 10, 2017
* MAX! Fix initiation issue Signed-off-by: Marcel Verpaalen <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Aug 12, 2023
The tables were wrong and confusing. I fixed the errors (reverse engineered from code), merged them into one, streamlined it so it shows the three relevant columns "Equipment", "Point" and "Property". Signed-off-by: Eiko Wagenknecht <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.