Declare connection on few bindings

[hmerk]

Done for bindings I am maintaining.

Signed-off-by: Hans-Jörg Merk [email protected]

Related to #14885

[jlaur]

Thanks!

[jlaur]

@hmerk - I don't know why the DCO passed, but it seems like your commits are not signed off? I see this:

[hmerk]

@hmerk - I don't know why the DCO passed, but it seems like your commits are not signed off? I see this:

Cause I manually set it to pass after it did not when I created the PR via web editing.

[hmerk]

CI build failure unrelated to this PR (failure reasoned by systeminfo tests).

[jlaur]

Cause I manually set it to pass after it did not when I created the PR via web editing.

I'm not sure if there is a GitHub option for configuring a sign-off for the web editor, but otherwise you can manually add the sign-off message when preparing your commit. Manually approving the DCO without sign-off doesn't really solve the problem. 🙂

[hmerk]

Manually approving the DCO without sign-off doesn't really solve the problem.

It does, as you can see, the DCO check is green.
I normally don't do web edits, but prefer proper PR's...
But will check how to set the options right.

EDIT: I think my Sign-off was just formatted incorrect.... Now it is corrected

[jlaur]

Manually approving the DCO without sign-off doesn't really solve the problem.

It does, as you can see, the DCO check is green.

The requirement is to have properly signed commits, not green DCO check:
https://www.openhab.org/docs/developer/contributing.html#sign-your-work

In your case the commit message must contain "Signed-off-by: Hans-Jörg Merk [email protected]" which I found in a previously merged pull request by you.

For this PR I will manually copy that sign-off message.