[tapocontrol] Support display light effects for L530 #14596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaur
changed the title
jlaur
requested changes
Mar 20, 2023
...ocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/api/TapoDeviceConnector.java
Outdated
Show resolved
Hide resolved
...ocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/api/TapoDeviceConnector.java
Show resolved
Hide resolved
...rol/src/main/java/org/openhab/binding/tapocontrol/internal/constants/TapoThingConstants.java
Show resolved
Hide resolved
...rol/src/main/java/org/openhab/binding/tapocontrol/internal/constants/TapoThingConstants.java
Show resolved
Hide resolved
bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/thing/L530.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/thing/L930.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/thing/L930.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/thing/L920.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/thing/L920.xml
Outdated
Show resolved
Hide resolved
color change is now possible if effect was already enabled by app Signed-off-by: Christian Wild <[email protected]>
jlaur
reviewed
Mar 23, 2023
...ntrol/src/main/java/org/openhab/binding/tapocontrol/internal/structures/TapoLightEffect.java
Outdated
Show resolved
Hide resolved
jlaur
requested changes
Mar 23, 2023
There was a problem hiding this comment.
Can you please regenerate the I18N properties file? See https://www.openhab.org/docs/developer/utils/i18n.html#generating-i18n-properties-file
Otherwise LGTM.
Co-authored-by: Jacob Laursen <[email protected]> Signed-off-by: Christian Wild <[email protected]>
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
* [tapocontrol] support display light effects for L530 color change is now possible if effect was already enabled by app Signed-off-by: Christian Wild <[email protected]>
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated L530 SmartBulb into LightEffects class.
Show active FX (ReadOnly)
Bugfix: Color change is now possible if effect was already enabled by app
L920 and L930 add effect-names to XML File
Removed effects from global xml file cause of different effects for each devicetype