Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unifi] Add support for guest Wi-Fi vouchers #14284

Merged
merged 3 commits into from
Jan 28, 2023
Merged

[unifi] Add support for guest Wi-Fi vouchers #14284

merged 3 commits into from
Jan 28, 2023

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Jan 27, 2023 •
edited
Loading

This PR adds support for creating guest wifi hotspot vouchers. The PR adds channels to the site thing for showing the next available hotspot voucher and triggering generation for new hotspot vouchers. Channel configuration paramaters allow tailoring the specifications of the vouchers generated.

Signed-off-by: Mark Herwege [email protected]

@mherwege
guest voucher support
31c4af3 
Signed-off-by: Mark Herwege <[email protected]>
@mherwege mherwege added the enhancement An enhancement or new feature for an existing add-on label Jan 27, 2023
@mherwege
update license headers
740c073 
Signed-off-by: Mark Herwege <[email protected]>
@mherwege mherwege changed the title [unifi] guest wifi vouchers [unifi] Guest wifi vouchers Jan 27, 2023
Hilbrand
Hilbrand reviewed Jan 27, 2023
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some style comments.

You could also consider adding an action with the parameters. That would make it possible to more dynamically create the vouchers from rules, and/or create virtual items where the user can set the configuration options that are passed when the rule is triggered.

...ng.unifi/src/main/java/org/openhab/binding/unifi/internal/handler/UniFiSiteThingHandler.java Outdated Show resolved Hide resolved
bundles/org.openhab.binding.unifi/src/main/resources/OH-INF/config/config.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.unifi/README.md Outdated Show resolved Hide resolved
@mherwege
Review feedback
d804b59 
Signed-off-by: Mark Herwege <[email protected]>
@mherwege
Copy link
Contributor Author

mherwege commented Jan 27, 2023 •
edited
Loading

@Hilbrand thank you for the quick review. I incorporated your feedback, but did not implement an action yet.
I have not done that before, so would need a bit more time for it. It makes sense though, but probably as an alternative to and on top of the simple solution with already in this PR. I can do this in this PR or do it in a follow-up PR.

Hilbrand
Hilbrand approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jlaur
jlaur approved these changes Jan 28, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature, looks good to me!

@jlaur jlaur merged commit 16f3a3e into openhab:main Jan 28, 2023
@jlaur jlaur added this to the 4.0 milestone Jan 28, 2023
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/unifi-binding-beta-3-2-0-4-0-0/131156/1

@mherwege mherwege mentioned this pull request Jan 31, 2023
Merged
@jlaur jlaur changed the title [unifi] Guest wifi vouchers [unifi] Add guest Wi-Fi vouchers Feb 5, 2023
@jlaur jlaur changed the title [unifi] Add guest Wi-Fi vouchers [unifi] Add support for guest Wi-Fi vouchers Feb 5, 2023
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@mherwege @nemerdaud
[unifi] Guest wifi vouchers (openhab#14284)
be27565 
* guest voucher support

Signed-off-by: Mark Herwege <[email protected]>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
@mherwege @renescherer
[unifi] Guest wifi vouchers (openhab#14284)
09f067a 
* guest voucher support

Signed-off-by: Mark Herwege <[email protected]>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
@mherwege @FordPrfkt
[unifi] Guest wifi vouchers (openhab#14284)
7acbb50 
* guest voucher support

Signed-off-by: Mark Herwege <[email protected]>
@lolodomo lolodomo mentioned this pull request May 5, 2023
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hilbrand Hilbrand Hilbrand approved these changes

@jlaur jlaur jlaur approved these changes

@mgbowman mgbowman Awaiting requested review from mgbowman mgbowman is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mherwege @openhab-bot @Hilbrand @jlaur