Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unifi] Added channels name and hostname to client things #14283

Merged
merged 2 commits into from
Jan 30, 2023
Merged

[unifi] Added channels name and hostname to client things #14283

merged 2 commits into from
Jan 30, 2023

Conversation

Hilbrand
Copy link
Member

No description provided.

@Hilbrand Hilbrand added the enhancement An enhancement or new feature for an existing add-on label Jan 27, 2023
@Hilbrand Hilbrand requested a review from mgbowman as a code owner January 27, 2023 13:49
jlaur
jlaur requested changes Jan 28, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the channels! I have only one question about the remaining mapping/inconsistency between alias and name. Maybe there is a good reason for keeping it, I'm just a little confused by having both.

...nding.unifi/src/main/java/org/openhab/binding/unifi/internal/api/cache/UniFiClientCache.java Outdated Show resolved Hide resolved
@Hilbrand
[unifi] Added channels name and hostname to client things.
3373708 
Signed-off-by: Hilbrand Bouwkamp <[email protected]>
@Hilbrand
[unifi] Review comments
5c817bd 
Also some changes related to the guestVoucher changes.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
jlaur
jlaur approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@jlaur jlaur merged commit bf10500 into openhab:main Jan 30, 2023
@jlaur jlaur added this to the 4.0 milestone Jan 30, 2023
@Hilbrand Hilbrand deleted the unifi-alias branch January 30, 2023 07:59
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@Hilbrand @nemerdaud
[unifi] Added channels name and hostname to client things. (openhab#1…
0eabfe3 
…4283)

* [unifi] Added channels name and hostname to client things.

Also some changes related to the guestVoucher changes.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
@Hilbrand @renescherer
[unifi] Added channels name and hostname to client things. (openhab#1…
66373da 
…4283)

* [unifi] Added channels name and hostname to client things.

Also some changes related to the guestVoucher changes.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
@Hilbrand @FordPrfkt
[unifi] Added channels name and hostname to client things. (openhab#1…
7105f3d 
…4283)

* [unifi] Added channels name and hostname to client things.

Also some changes related to the guestVoucher changes.

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
@lolodomo lolodomo mentioned this pull request May 5, 2023
Closed
29 tasks
@jlaur jlaur changed the title [unifi] Added channels name and hostname to client things. [unifi] Added channels name and hostname to client things Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@mgbowman mgbowman Awaiting requested review from mgbowman mgbowman is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Hilbrand @jlaur