Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gree] Fix thing-type min state #14219

Merged
merged 1 commit into from
Jan 14, 2023
Merged

[gree] Fix thing-type min state #14219

merged 1 commit into from
Jan 14, 2023

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Jan 14, 2023

Signed-off-by: lsiepel [email protected]

Fix comment: #14217 (comment)

@lsiepel lsiepel requested a review from markus7017 as a code owner January 14, 2023 11:32
@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes. labels Jan 14, 2023
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit 649da66 into openhab:main Jan 14, 2023
@jlaur jlaur added this to the 4.0 milestone Jan 14, 2023
@lsiepel
Copy link
Contributor Author

lsiepel commented Jan 14, 2023

I think the bug label should be removed as it is not needed to show up in the release notes. This one is tied closely (and a forgotten change) to #14217

@lsiepel lsiepel deleted the gree-adjustment branch January 14, 2023 13:33
@jlaur
Copy link
Contributor

jlaur commented Jan 14, 2023

@lsiepel - it will be excluded from the release notes when "regression" is also present. 🙂

@lsiepel
Copy link
Contributor Author

lsiepel commented Jan 14, 2023

notes whe

ah, didn't knwo that, thanks!

@jlaur
Copy link
Contributor

jlaur commented Jan 14, 2023

notes whe

ah, didn't knwo that, thanks!

It's quite new. It makes it easier to manage what will show up in the release notes since labels can be applied immediately without remembering to go back and maintain them later. Also we can correctly categorize bugs that should not be mentioned.

nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants