-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hueemulation] Fix for Alexa failing to discover all devices. #13923
Conversation
Signed-off-by: Mike Major <[email protected]>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/oh3-hue-emulation-bug/139875/16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a change that will potentially break OH already setup by users ?
....openhab.io.hueemulation/src/main/java/org/openhab/io/hueemulation/internal/ConfigStore.java
Outdated
Show resolved
Hide resolved
@lolodomo Users might have to rescan their devices following the id change. |
You mean in the hue app? I am not sure the timing is good while we are now in the few last days before the release GA with expected restricted changes/merges. |
Signed-off-by: Mike Major <[email protected]>
Its whatever is talking to the Hue Emulator, e.g. Alexa, Logitech Harmony, etc that might need a device rescan depending on what they do with that unique id. I wasn't expecting this to be merged straight away due to the pending 3.4 release. |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/hueemulation-binding-not-detecting-new-devices/141401/4 |
Please submit an entry in update.lst to explain the breaking change. |
See: openhab/openhab-addons#13923 Signed-off-by: Mike Major <[email protected]>
…b#13923) * Fix for Alexa failing to discover all devices. Signed-off-by: Mike Major <[email protected]>
Is there plans for this fix to be merged in to the 3.4 branch? |
…b#13923) * Fix for Alexa failing to discover all devices. Signed-off-by: Mike Major <[email protected]>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/alexa-cant-find-more-new-hue-devices/145384/2 |
…b#13923) * Fix for Alexa failing to discover all devices. Signed-off-by: Mike Major <[email protected]>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/oh3-hue-emulation-bug/139875/20 |
Alexa currently fails to discover devices which have an internal hue id greater than 255. This appears to be due to the value of the uniqueid which is not in the format described in the hue API when the value exceeds 255.
Reports of issue and fix tested
Signed-off-by: Mike Major [email protected]