Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hueemulation] Fix for Alexa failing to discover all devices. #13923

Merged
merged 2 commits into from
Dec 27, 2022

Conversation

MikeJMajor
Copy link
Contributor

Alexa currently fails to discover devices which have an internal hue id greater than 255. This appears to be due to the value of the uniqueid which is not in the format described in the hue API when the value exceeds 255.

Reports of issue and fix tested

Signed-off-by: Mike Major [email protected]

@MikeJMajor MikeJMajor added the bug An unexpected problem or unintended behavior of an add-on label Dec 12, 2022
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh3-hue-emulation-bug/139875/16

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a change that will potentially break OH already setup by users ?

@MikeJMajor
Copy link
Contributor Author

@lolodomo Users might have to rescan their devices following the id change.

@lolodomo
Copy link
Contributor

lolodomo commented Dec 13, 2022

Users might have to rescan their devices following the id change.

You mean in the hue app?

I am not sure the timing is good while we are now in the few last days before the release GA with expected restricted changes/merges.

@MikeJMajor
Copy link
Contributor Author

You mean in the hue app?

I am not sure the timing is good while we are now in the few last days before the release GA with expected restricted changes/merges.

Its whatever is talking to the Hue Emulator, e.g. Alexa, Logitech Harmony, etc that might need a device rescan depending on what they do with that unique id.

I wasn't expecting this to be merged straight away due to the pending 3.4 release.

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/hueemulation-binding-not-detecting-new-devices/141401/4

@MikeJMajor MikeJMajor requested a review from lolodomo December 19, 2022 14:06
@lolodomo lolodomo merged commit a4a8d5d into openhab:main Dec 27, 2022
@lolodomo lolodomo added this to the 4.0 milestone Dec 27, 2022
@lolodomo
Copy link
Contributor

lolodomo commented Dec 27, 2022

Please submit an entry in update.lst to explain the breaking change.
Take the following PR as example of what file to update and how to do it:
openhab/openhab-distro#1449

wborn pushed a commit to openhab/openhab-distro that referenced this pull request Dec 29, 2022
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
…b#13923)

* Fix for Alexa failing to discover all devices.

Signed-off-by: Mike Major <[email protected]>
@azntech
Copy link

azntech commented Feb 7, 2023

Is there plans for this fix to be merged in to the 3.4 branch?

@MikeJMajor MikeJMajor deleted the hueemu2 branch February 7, 2023 20:59
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
…b#13923)

* Fix for Alexa failing to discover all devices.

Signed-off-by: Mike Major <[email protected]>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/alexa-cant-find-more-new-hue-devices/145384/2

renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
…b#13923)

* Fix for Alexa failing to discover all devices.

Signed-off-by: Mike Major <[email protected]>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh3-hue-emulation-bug/139875/20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants