Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hdpowerview] Add console extension for showing IDs #13615

Merged
merged 1 commit into from
Oct 28, 2022
Merged

[hdpowerview] Add console extension for showing IDs #13615

merged 1 commit into from
Oct 28, 2022

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Oct 28, 2022

Example session:

openhab> openhab:hdpowerview showIds
API bridge: PowerView Hub
 - Shades:
    - ID: 23137 (Gardin 7)
    - ID: 24076 (Gardin 10)
    - ID: 32544 (Gardin 6)
    - ID: 58120 (Gardin 2)
    - ID: 34896 (Gardin 5)
    - ID: 5868 (Gardin 8)
    - ID: 38196 (Gardin 1)
    - ID: 46532 (Gardin 3)
    - ID: 42949 (Gardin 4)
    - ID: 36137 (Gardin 11)
    - ID: 24927 (Gardin 9)
 - Repeaters:
    - ID: 17805 (Repeater soveværelse)

Fixes #13614
Depends on openhab/openhab-core#3111

@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Oct 28, 2022
@jlaur jlaur requested a review from a team October 28, 2022 12:10
@andrewfg
Copy link
Contributor

@jlaur brilliant! We will of course also need it for Gen 3..

andrewfg
andrewfg approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@andrewfg
Copy link
Contributor

Albeit (nota bene to self) your code will have to be extended to include support for gateway bridges resp. shade3 things.

@jlaur jlaur mentioned this pull request Oct 28, 2022
Merged
lolodomo
lolodomo approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit af4657f into openhab:main Oct 28, 2022
@lolodomo lolodomo added this to the 3.4 milestone Oct 28, 2022
@jlaur jlaur deleted the 13614-hdpowerview-console-show-ids branch November 5, 2022 18:48
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@jlaur @andan67
Add console extension for showing IDs (openhab#13615)
2a55be1 
Fixes openhab#13614

Signed-off-by: Jacob Laursen <[email protected]>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@jlaur @andrasU
Add console extension for showing IDs (openhab#13615)
34cd489 
Fixes openhab#13614

Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Andras Uhrin <[email protected]>
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
@jlaur @borazslo
Add console extension for showing IDs (openhab#13615)
d8bbcbe 
Fixes openhab#13614

Signed-off-by: Jacob Laursen <[email protected]>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@jlaur @psmedley
Add console extension for showing IDs (openhab#13615)
2f4c0b8 
Fixes openhab#13614

Signed-off-by: Jacob Laursen <[email protected]>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@jlaur @nemerdaud
Add console extension for showing IDs (openhab#13615)
a7402c9 
Fixes openhab#13614

Signed-off-by: Jacob Laursen <[email protected]>
@jlaur jlaur mentioned this pull request Mar 19, 2023
Merged
@GerdZanker GerdZanker mentioned this pull request Mar 27, 2023
Closed
@GerdZanker GerdZanker mentioned this pull request Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewfg andrewfg andrewfg approved these changes

@lolodomo lolodomo lolodomo approved these changes

@andylintner andylintner Awaiting requested review from andylintner andylintner is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

[hdpowerview] Console command for identifying shade/repeater IDs
3 participants
@jlaur @andrewfg @lolodomo