[liquidcheck] Initial contribution #13287

marcelGoerentz · 2022-08-18T13:16:11Z

Signed-off-by: Marcel Goerentz [email protected]

[liquidcheck] Initial contribution

Description

Adding a new binding so users can connect openHAB to Liquid-Check devices.
This binding integrates the sensor to the users home automation with little configuration effort.

Testing

Binding has been tested with hardware version B and firmware version 1.60 of the device.

marcelGoerentz · 2022-08-26T13:57:26Z

Hey guys,

I'm just curious if someone is reviewing my binding.
I'm looking forward to your comments.

jlaur · 2022-09-06T20:45:33Z

I'm just curious if someone is reviewing my binding.

Hi @marcelGoerentz, thanks for your contribution. Just wanted to let you know that we currently have a lot of PR's to review (including other new bindings as well), so please expect some additional time until a maintainer will be able to perform a full review. Sorry for the inconvenience.

lolodomo

Review part 1 of 3

bundles/org.openhab.binding.liquidcheck/README.md

bundles/org.openhab.binding.liquidcheck/src/main/resources/OH-INF/thing/thing-types.xml

bundles/org.openhab.binding.liquidcheck/README.md

...les/org.openhab.binding.liquidcheck/src/main/resources/OH-INF/i18n/liquidcheck_en.properties

bundles/org.openhab.binding.liquidcheck/src/main/resources/OH-INF/thing/thing-types.xml

...heck/src/main/java/org/openhab/binding/liquidcheck/internal/LiquidCheckBindingConstants.java

marcelGoerentz · 2022-11-14T12:41:24Z

Hey @lolodomo,

thank you for your review. I appreciate it very much.
I've adjusted most of the points that you mentioned.

jlaur

@lolodomo beat me in finding proper amount of time to go through your PR. 😄 So I will just post old minor comments from some time ago when I was having a brief look.

...heck/src/main/java/org/openhab/binding/liquidcheck/internal/LiquidCheckBindingConstants.java

bundles/org.openhab.binding.liquidcheck/README.md

Signed-off-by: Marcel Goerentz <[email protected]>

lolodomo · 2023-03-25T16:32:47Z

@lolodomo - would you like to finish your review?

Feel free to finish the review and merge without waiting for me.

jlaur · 2023-03-26T12:10:31Z

@lolodomo - would you like to finish your review?

Feel free to finish the review and merge without waiting for me.

I have not fully reviewed, because I saw you already did. Just wanted to check if there was still something pending from your side preventing a merge, because review comments seemed to have been addressed.

...dcheck/src/main/java/org/openhab/binding/liquidcheck/internal/LiquidCheckHandlerFactory.java

Signed-off-by: Marcel Goerentz <[email protected]>

jlaur · 2023-03-28T10:44:06Z

@lolodomo - would you like to finish your review?

Feel free to finish the review and merge without waiting for me.

I have not fully reviewed, because I saw you already did. Just wanted to check if there was still something pending from your side preventing a merge, because review comments seemed to have been addressed.

@lolodomo - gentle ping. If your review is concluded, please approve. The few comments from my side are resolved, but as said, I haven't reviewed, so would appreciate your confirmation.

Signed-off-by: Marcel Goerentz <[email protected]>

…n response may contain a double. Signed-off-by: marcelGoerentz <[email protected]>

Signed-off-by: marcelGoerentz <[email protected]>

jlaur

I'm trusting @lolodomo already reviewed this PR. Let's get it finished and merged. I have just a few additional comments after going through changed files.

...ain/java/org/openhab/binding/liquidcheck/internal/discovery/LiquidCheckDiscoveryService.java

...g.liquidcheck/src/main/java/org/openhab/binding/liquidcheck/internal/LiquidCheckHandler.java

bundles/org.openhab.binding.liquidcheck/README.md

…minor changes in handler Signed-off-by: Marcel Goerentz <[email protected]>

…ab-addons into liquidcheck

Signed-off-by: marcelGoerentz <[email protected]>

jlaur

Almost there. 🙂

...g.liquidcheck/src/main/java/org/openhab/binding/liquidcheck/internal/LiquidCheckHandler.java

...src/main/java/org/openhab/binding/liquidcheck/internal/httpclient/LiquidCheckHttpClient.java

...g.liquidcheck/src/main/java/org/openhab/binding/liquidcheck/internal/LiquidCheckHandler.java

Signed-off-by: marcelGoerentz <[email protected]>

jlaur

Sorry, this fell off my radar. I checked the last two commits and provided two additional comments.

...g.liquidcheck/src/main/java/org/openhab/binding/liquidcheck/internal/LiquidCheckHandler.java

...src/main/java/org/openhab/binding/liquidcheck/internal/httpclient/LiquidCheckHttpClient.java

Signed-off-by: marcelGoerentz <[email protected]>

Signed-off-by: Marcel Goerentz <[email protected]>

jlaur

Thank you for your contribution and your patience. Let's merge this binding and hopefully get it more widely tested with the next milestone release. If any issues are later found leading to an explanation why you needed to start the shared http client, this can be fixed in a follow-up PR.

Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

* Add new binding liquidcheck Signed-off-by: Marcel Goerentz <[email protected]> Signed-off-by: Thomas Burri <[email protected]>

* Add new binding liquidcheck Signed-off-by: Marcel Goerentz <[email protected]> Signed-off-by: Matt Myers <[email protected]>

* Add new binding liquidcheck Signed-off-by: Marcel Goerentz <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>

marcelGoerentz requested a review from a team as a code owner August 18, 2022 13:16

marcelGoerentz changed the title ~~Add new binding liquidcheck~~ [liquidcheck] Initial contribution Aug 18, 2022

jlaur added the new binding If someone has started to work on a binding. For a new binding PR. label Aug 20, 2022

marcelGoerentz force-pushed the liquidcheck branch from 6ba36f5 to d88ac78 Compare September 2, 2022 10:54

lolodomo requested changes Nov 12, 2022

View reviewed changes

jlaur requested changes Nov 14, 2022

View reviewed changes

marcelGoerentz force-pushed the liquidcheck branch from 1357a59 to 09ec60e Compare November 14, 2022 12:55

marcelGoerentz requested review from svilenvul, dalgwen, jochen314, hmerk, gs4711, andrewfg, mherwege, mgbowman, Hilbrand, pacive, markus7017, mlobstein, pail23, davidgraeff, weymann, bobadair, clinique, octa22, bruestel and andylintner as code owners November 14, 2022 12:55

[liquidcheck] Update README.md and generate new liquidcheck.properties

20b2c7a

Signed-off-by: Marcel Goerentz <[email protected]>

jlaur reviewed Mar 26, 2023

View reviewed changes

...dcheck/src/main/java/org/openhab/binding/liquidcheck/internal/LiquidCheckHandlerFactory.java Outdated Show resolved Hide resolved

[liquidcheck] Fix typo in handler factory

4687742

Signed-off-by: Marcel Goerentz <[email protected]>

marcelGoerentz added 5 commits March 29, 2023 10:24

[liquidcheck] Change channel id naming

4e16e37

Signed-off-by: Marcel Goerentz <[email protected]>

[liquidcheck] Change channel id naming in README.md

664ad52

Signed-off-by: Marcel Goerentz <[email protected]>

[liquidcheck] Change channel id naming in README.md part 2

67ca14f

Signed-off-by: Marcel Goerentz <[email protected]>

[liquidcheck] Change Measure.conten from int to double, since the jso…

e851808

…n response may contain a double. Signed-off-by: marcelGoerentz <[email protected]>

[liquidcheck] Fix response test

39a48bd

Signed-off-by: marcelGoerentz <[email protected]>

jlaur requested changes Apr 5, 2023

View reviewed changes

marcelGoerentz added 3 commits April 5, 2023 14:53

[liquidcheck] Update README.md, fix typo in discovery service and do …

73410d5

…minor changes in handler Signed-off-by: Marcel Goerentz <[email protected]>

Merge branch 'liquidcheck' of https://github.com/marcelGoerentz/openh…

7d40752

…ab-addons into liquidcheck

[liquidcheck] Update Handler and fix typos

426064c

Signed-off-by: marcelGoerentz <[email protected]>

jlaur requested changes Apr 5, 2023

View reviewed changes

marcelGoerentz added 2 commits April 8, 2023 12:33

[liquidcheck] Simplify the initialization

95f8abd

Signed-off-by: marcelGoerentz <[email protected]>

[liquidcheck] Fix thin status update

ac3cac3

Signed-off-by: marcelGoerentz <[email protected]>

jlaur requested changes Apr 13, 2023

View reviewed changes

...g.liquidcheck/src/main/java/org/openhab/binding/liquidcheck/internal/LiquidCheckHandler.java Outdated Show resolved Hide resolved

...src/main/java/org/openhab/binding/liquidcheck/internal/httpclient/LiquidCheckHttpClient.java Outdated Show resolved Hide resolved

marcelGoerentz added 2 commits April 16, 2023 20:40

[liquidcheck] Simplify status update

de2f89a

Signed-off-by: marcelGoerentz <[email protected]>

[liquidcheck] Delete client start as not necessary

de24c45

Signed-off-by: Marcel Goerentz <[email protected]>

jlaur added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels May 13, 2023

jlaur approved these changes May 13, 2023

View reviewed changes

jlaur merged commit ab16c94 into openhab:main May 13, 2023

jlaur added this to the 4.0 milestone May 13, 2023

marcelGoerentz mentioned this pull request May 17, 2023

[LiquidCheck] Add image for new binding openhab/openhab-docs#2080

Merged

tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023

[liquidcheck] Initial contribution (openhab#13287)

cd35021

* Add new binding liquidcheck Signed-off-by: Marcel Goerentz <[email protected]> Signed-off-by: Thomas Burri <[email protected]>

matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023

[liquidcheck] Initial contribution (openhab#13287)

4050234

* Add new binding liquidcheck Signed-off-by: Marcel Goerentz <[email protected]> Signed-off-by: Matt Myers <[email protected]>

austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024

[liquidcheck] Initial contribution (openhab#13287)

44e4431

* Add new binding liquidcheck Signed-off-by: Marcel Goerentz <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[liquidcheck] Initial contribution #13287

[liquidcheck] Initial contribution #13287

marcelGoerentz commented Aug 18, 2022 •

edited

Loading

marcelGoerentz commented Aug 26, 2022

jlaur commented Sep 6, 2022

lolodomo left a comment

marcelGoerentz commented Nov 14, 2022

jlaur left a comment

lolodomo commented Mar 25, 2023

jlaur commented Mar 26, 2023

jlaur commented Mar 28, 2023

jlaur left a comment

jlaur left a comment

jlaur left a comment

jlaur left a comment •

edited

Loading

[liquidcheck] Initial contribution #13287

[liquidcheck] Initial contribution #13287

Conversation

marcelGoerentz commented Aug 18, 2022 • edited Loading

[liquidcheck] Initial contribution

Description

Testing

marcelGoerentz commented Aug 26, 2022

jlaur commented Sep 6, 2022

lolodomo left a comment

Choose a reason for hiding this comment

marcelGoerentz commented Nov 14, 2022

jlaur left a comment

Choose a reason for hiding this comment

lolodomo commented Mar 25, 2023

jlaur commented Mar 26, 2023

jlaur commented Mar 28, 2023

jlaur left a comment

Choose a reason for hiding this comment

jlaur left a comment

Choose a reason for hiding this comment

jlaur left a comment

Choose a reason for hiding this comment

jlaur left a comment • edited Loading

Choose a reason for hiding this comment

marcelGoerentz commented Aug 18, 2022 •

edited

Loading

jlaur left a comment •

edited

Loading