Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bosch Indego Connect Binding #1202

Merged
merged 58 commits into from
Feb 2, 2017
Merged

Bosch Indego Connect Binding #1202

merged 58 commits into from
Feb 2, 2017

Conversation

jofleck
Copy link

@jofleck jofleck commented Aug 22, 2016

Signed-off-by: Jonas Fleck [email protected] (github: jofleck)

jofleck added 24 commits August 17, 2016 17:42
@jofleck
Initial commit
e336084
@jofleck
Remove debug messages
53a2ccb
@jofleck
Change parameters of the lib
a74065a
@jofleck
Change binding description
54dda24
@jofleck
Add errorcode channel
e7ed2cc
@jofleck
Increased minimum refresh interval to 60 seconds
6e693f7
@jofleck
Add channel which shows if the mower is ready
deabe4d
@jofleck
Add statecode channel
c00a8d9
@jofleck
Add Map files for the statecodes
0b309e5
@jofleck
Handle refreshtype command
5b77620
@jofleck
Add README
ec8faa9
@jofleck
Merge pull request #1 from jofleck/Indego-Binding
631e536 
Indego binding
@jofleck
Initial commit
818523f
@jofleck
Remove debug messages
5684933
@jofleck
Change parameters of the lib
d11b6ac
@jofleck
Change binding description
fa49ec2
@jofleck
Add errorcode channel
2b51c3e
@jofleck
Increased minimum refresh interval to 60 seconds
6374d33
@jofleck
Add channel which shows if the mower is ready
2582d99
@jofleck
Add statecode channel
fe7cf26
@jofleck
Add Map files for the statecodes
18a8855
@jofleck
Handle refreshtype command
9a42c59
@jofleck
Add README
51acbec
@jofleck
Merge branch 'master' of https://github.com/jofleck/openhab2-addons
012d6b0
sjsf
sjsf reviewed Aug 26, 2016
View reviewed changes
addons/binding/org.openhab.binding.boschindego/ESH-INF/i18n/boschindego_xx_XX.properties
@@ -0,0 +1,11 @@
# binding
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this got in by accident...?

@jofleck
Copy link
Author

jofleck commented Aug 26, 2016

Allright, i will remove the i18n folder and update the channel descriptions. Thanks for your feedback!

sjsf
sjsf reviewed Aug 26, 2016
View reviewed changes
...ng.boschindego/src/main/java/org/openhab/binding/boschindego/handler/BoschIndegoHandler.java
controller.sendCommand(getCommandFromEshStatus(commandToSend));
commandToSend = 0;
try {
for (int i = 0; i < 30; i++) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you should also check for && !Thread.isInterrupted()

@jofleck
Copy link
Author

jofleck commented Jan 6, 2017

I've changed everything according to your feedback except the pom file. Im not able to test the code in detail because it's too cold in the moment.

In the meantime you can look at the code again?

When it´s warm enough to test the mower in action I will rebase my fork and solve the merge conflict with the pom file.

kaikreuzer
kaikreuzer requested changes Jan 10, 2017
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jofleck - hoping for warmer weather soon again :-)
Checking the code, it seems you still missed a few of the previous comments. If you think, some comment does not make sense, just let me know.

addons/binding/org.openhab.binding.boschindego/META-INF/MANIFEST.MF
lib/commons-codec-1.9.jar,
lib/commons-logging-1.2.jar
Import-Package:
com.fasterxml.jackson.annotation;version="2.4.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the version constraints

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhh okay. Maybe this solves the problem with the different HTTP requests too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt that this will make any difference...

addons/binding/org.openhab.binding.boschindego/META-INF/MANIFEST.MF
lib/bosch-indego-controller-lib-0.8.jar,
lib/httpclient-4.5.2.jar,
lib/httpcore-4.4.4.jar,
lib/commons-codec-1.9.jar,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if I asked that on my initial review, but do you really need to bundle commons-codec and commons-logging? codec 1.6 is part of openHAB already and commons-logging should not be necessary as we have slf4j-api in place.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that. But I noticed that the library doesn't work with the "older" commons. The http requests are different

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, codec should not do any HTTP requests, does it? Note that you of course have to do Package-Imports of all required Java packages to make the classes available to the indego library.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commons-logging is needed because it is an dependency of the apache http client. Its not used. I used the logging lib included in openHAB. Removing the version tags solved the problems with the different http requests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not used, it can be removed. The http client will require the Java package "org.apache.commons.logging", so you should add a Package-Import for this. Then you can get rid off this library.

@jofleck
Copy link
Author

jofleck commented Jan 30, 2017

Here is a video of a short demo

@kaikreuzer kaikreuzer removed the awaiting feedback Awaiting feedback from the pull request author label Feb 1, 2017
@kaikreuzer
Copy link
Member

Thanks, @jofleck looks all good to me now!

@kaikreuzer kaikreuzer merged commit 1022fb9 into openhab:master Feb 2, 2017
Markinus pushed a commit to Markinus/openhab2-addons that referenced this pull request Feb 8, 2017
@jofleck @Markinus
Bosch Indego Connect Binding (openhab#1202)
19d2c3e 
Bosch Indego Connect Binding

Signed-off-by: Jonas Fleck [email protected] (github: jofleck)
fharni pushed a commit to fharni/openhab2-addons that referenced this pull request Feb 10, 2017
@jofleck @fharni
Bosch Indego Connect Binding (openhab#1202)
2655811 
Bosch Indego Connect Binding

Signed-off-by: Jonas Fleck [email protected] (github: jofleck)
jarlebh pushed a commit to jarlebh/openhab2-addons that referenced this pull request Mar 4, 2017
@jofleck @jarlebh
Bosch Indego Connect Binding (openhab#1202)
7ac54d1 
Bosch Indego Connect Binding

Signed-off-by: Jonas Fleck [email protected] (github: jofleck)
tratho pushed a commit to tratho/openhab2-addons that referenced this pull request May 5, 2017
@jofleck @tratho
Bosch Indego Connect Binding (openhab#1202)
df10d50 
Bosch Indego Connect Binding

Signed-off-by: Jonas Fleck [email protected] (github: jofleck)
@kaikreuzer kaikreuzer modified the milestone: 2.1 Jun 24, 2017
@GRORI GRORI mentioned this pull request Feb 1, 2018
Merged
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Aug 12, 2023
@ghys @mstormi
@mrbig @LinqLover @rwdrich @jwaes @bracklanna @cpmeister @Rossko57 @cweitkamp @Skinah @paulianttila @ljsquare @PatrikG8 @BrutalBirdie @wasv @theiding @jadcx @bjorn-helgaas @robnielsen @GumbyMan82 @cfergeau @jcranky @Rosi2143 @bugsmurf @Confectrician @josefscript @wborn @ssalonen @fwolter @vringar @TRSx80 @sihui62 @amil109 @olivbd @andrewfg @LeeC77 @toweosp @garretcook @microneer
Merge 2.5.x into main (openhab#1266)
d72156a 
* Update README (2.5.x) (openhab#1153)

Change branch name.

Signed-off-by: Yannick Schaus <[email protected]>

* Update items.md (openhab#1156)

* Added var and VA units to UoM (openhab#1146)

VA (Volt-Ampere - apparent power) and var (Volt-Ampere reactive) are used to measure power and energy consumption in AC circuits.


Signed-off-by: Nagy Attila Gabor <[email protected]>

* Fix filepath to keystore (openhab#1148)

Default openHAB userdata environment variable should be `$OPENHAB_USERDATA`, not `$USER_DATA` shouldn't it? At least, this is the default on my fresh openHABian and also the most popular variant to find in the docs.

* Slight language corrections (openhab#1150)

I think it reads better this way

Signed-off-by: Richard Davies <[email protected]>

* additional example for non default persistence service (openhab#1152)

For me it was confusing how to pass on the serviceId into methods that already had an argument. An extra example is always good.

Signed-off-by: jaco <[email protected]>

* Adding 12 new logos for OH Add-Ons page on website (openhab#1158)

Signed-off-by: bracklanna [email protected]

* Added missing preset variables (openhab#1104)

* Added missing preset variables

Signed-off-by: Scott Rushworth <[email protected]>

* Cleaned up blank lines, fixed table, and added file name for SimpleRule

Signed-off-by: Scott Rushworth <[email protected]>

* Fix broken link (openhab#1165)

* Added Hotlink from "label" section to "state presentation" (openhab#1167)

* Added note about broken action (openhab#1164)

* Added note about broken action

See openhab/openhab-core#1374

Signed-off-by: Christoph Weitkamp <[email protected]>

* Incorporated changes from review

Signed-off-by: Christoph Weitkamp <[email protected]>

* Incorporated changes from review

Signed-off-by: Christoph Weitkamp <[email protected]>

* Update index.md (openhab#1170)

Link appears to be wrong and does not work when I click on it in Edge. Loads the same page again instead of loading the correct new page from the hyperlink.

https://www.openhab.org/docs/developer/guidelines.html

* Added Airthings logo (openhab#1171)

* typo in exambp (openhab#1172)

`Temperature.averageSince(now.minusMinutes(5),"influxdb")`

* file.encoding=UTF-8 (openhab#1173)

* Update demo URL and add demo.rules URL (openhab#1174)

Based on: https://community.openhab.org/t/demo-setup-missing/94850
Old Link is broken leading to 404.
The link to the demo.rules on github is an extra :)

* Replace outdated zulu.org link. (openhab#1177)

* Replace outdated zulu.org link.

As of 3/23/2020 zulu.org has an SSL cert that expired on 9/28/2019. Changed link to azul.com/downloads, since that appears to be the new official source.

Signed-off-by: Billy Stevens <[email protected]>

* Changed all http links to https for installation/index.md.

All changed links working, tested on 3/24/2020.

Signed-off-by: Billy Stevens <[email protected]>

* Minor language tweak (openhab#1178)

* Ending an active scan/stopScan (openhab#1179)

Signed-off-by: Mark Theiding <[email protected]>

* Add files via upload (openhab#1184)

* Update persistence.md (openhab#1185)

Clarify return objects for max/min rules extensions.

Signed-off-by: Ross Kennedy [email protected]

* Update things.md (openhab#1186)

Amended example code to include using label and location when defining a Thing with a bridge that is defined elsewhere.

* Correct typos (openhab#1190)

* Correct usage of its/it's

"It's" is always a contraction of "it is" or "it has".  "Its" is a
possessive.  Correct a few places where they were used backwards.

Signed-off-by: Bjorn Helgaas <[email protected]>

* Correct "Z-Wave" spelling

Per https://www.z-wave.com/, the canonical spelling appears to be "Z-Wave".
Most places use "Z-Wave" already; change the remaining references to match.

Signed-off-by: Bjorn Helgaas <[email protected]>

* Correct typos and grammatical errors

Correct some typos and grammatical errors.

Signed-off-by: Bjorn Helgaas <[email protected]>

* Update sitemap.md section charts (openhab#1191)

I observed that the unique first word in the labels of items charted in a group isn't causing an empty chart anymore. I'm on openHAB 2.5.1.

Signed-off-by: Juergen Baginski [email protected]

* Add image for insteon binding (openhab#1196)

Signed-off-by: Rob Nielsen <[email protected]>

* typo (openhab#1198)

Signed-off-by: Mark Theiding <[email protected]>

* Installation details (openhab#1197)

Added more details around the installation and configuration process.
Fixed that engine no longer logs "Activated scripting support..."

Signed-off-by: Mark Theiding <[email protected]>

* Update sitemaps.md (openhab#1202)

Added full item definition for usage of visibility. See https://community.openhab.org/t/sitemap-visibility-basic-ui/97304/9

* Updated ecobee logo (https://brand.ecobee.com/) (openhab#1203)

Signed-off-by: Rob Nielsen <[email protected]>

* tutorial: Fix description of sitemap 'type' (openhab#1204)

In the tutorial, the generic sitemap description says that ItemType has
to be the same as the type defined in default.items.
Looking at
https://www.openhab.org/docs/configuration/items.html#type and
https://www.openhab.org/docs/configuration/sitemaps.html#element-types
this is incorrect as they take different values.
The example is even mislading as `Switch` is one of the only types which
is common between items and sitemaps. Might be better to describe
`Default` instead.

Signed-off-by: Christophe Fergeau <[email protected]>

* Added information about DateTime Group functions LATEST/EARLIEST (openhab#1206)

Signed-off-by: Christoph Weitkamp <[email protected]>

* Add section for documentation contributions (openhab#1205)

Hopefully this will lower the hurdle for people to submit documentation contributions. I know from myself that I didn't submit various documentation improvements, because I didn't know git and thought it would be a much more involved process. 
Ideally there would be a separate documentation section, but submitting this under the development contribution page for now (as per discussion with @Confectrician in openhab/openhab-docs#1179 (comment)).
Note that I am addressing the issue of DCO failures wrt specifying the full name that I ran into myself in openhab/openhab-docs#1197 (comment). I found a good discussion of the issue at dcoapp/app#43.

Signed-off-by: Mark Theiding <[email protected]>

* fix typo (openhab#1209)

* add description of Ephemeris localization support (openhab#1210)

Add a new section to describe the localization support and how-to steps

Signed-off-by: Michael Roßner [email protected]

* Line 115 broken link - should be: (openhab#1217)

* Line 115 broken link - should be:

({{base}}/docs/configuration/sitemaps.html#element-types)

was:
({{base}}/configuration/configuration/sitemaps.html#element-types)

* Removed diplicated docs breadcrumb

Signed-off-by: Jerome Luckenbach <[email protected]>

Co-authored-by: Jerome Luckenbach <[email protected]>

* add missing space between words (openhab#1212)

* Update configuration.md (openhab#1215)

I'm a beginner myself. Though I liked this tutorial very much, it took me some time trying and erroring and finally reading forum posts to get behind this. I didn't even know there was something like a more modern ping. So maybe others are happy to learn this right from the beginning.

* Remove architecture from Docker tags (openhab#1220)

Docker automatically detects the architecture and downloads the appropriate image (openhab/openhab-docker#213).
BuildKit will no longer generate new tags having the architecture (openhab/openhab-docker#293).

Signed-off-by: Wouter Born <[email protected]>

* slight readability improvements (openhab#1221)

* slight readability improvements

* Update introduction.md

* Update introduction.md

* minor wording update

* Update eclipse.md (openhab#1225)

Clarifying that it's no longer possible to make changes in the Core Framework for 2.5.x.

Signed-off-by: Mark Theiding <[email protected]>

* [fmiweather] logo for FMI Weather binding (openhab#929)

Signed-off-by: Sami Salonen <[email protected]>

* Update eclipse.md (openhab#1226)

Added additional structure around install, run, debug and update steps. Provided more pointers to interactions with Eclipse, Maven and Git.

Signed-off-by: Mark Theiding <[email protected]>

* Update contributing.md (openhab#1227)

Need to escape \< and \> in the sign off message format so users see them explicitly in the Contributing to the Documentation section. 

Signed-off-by: Mark Theiding <[email protected]>

* Update contributing.md (openhab#1228)

Small refinement on documentation change submission flow. 

Signed-off-by: Mark Theiding <[email protected]>

* Add doc folder to the binding directory structure (openhab#1230)

Signed-off-by: Fabian Wolter <[email protected]>

* Make Subheadings Use Proper Subheading Syntax (openhab#1234)

This way they render out as proper markdown and don't look weird on the website

Signed-off-by: Stefan Zabka <[email protected]>

* Remove unnecessary isCancelled() from code example (openhab#1235)

Cancelling an already canceled task has no effect. IMHO this check is not necesssary and removal would simplify the code. I came to this because I saw this pattern in many bindings during reviewing.

Signed-off-by: Fabian Wolter <[email protected]>

* Update thing-xml.md (openhab#1236)

Signed-off-by: Christoph Weitkamp <[email protected]>

* Fix broken ESH links (openhab#1231)

Signed-off-by: Wouter Born <[email protected]>

* Update logging.md (openhab#1238)

Add information on how to find out the symbolic names of the bundles

* Remove Apache Commons from Default Libraries (openhab#1229)

See openhab#7722
Signed-off-by: Fabian Wolter <[email protected]>

* Update introduction.md (openhab#1239)

* Update introduction.md

Signed-off-by: Markus Storm [email protected]

* Update introduction.md

* Revise Java recommendations (openhab#1240)

* Revise Java recommendations

* Delete pine.md

Do not recommend PINE, it's not supported any longer by openHABian.

* Removed sidebar link in config

Signed-off-by: Jerome Luckenbach <[email protected]>

Co-authored-by: Jerome Luckenbach <[email protected]>

* Update security.md (openhab#1241)

Been using FreeDNS for many years (ever since all these companies got rid of their free tiers) and never an issue!

* Fix DecimalType hex conversion example (openhab#1243)

See: openhab/openhab-core#1526

Signed-off-by: Wouter Born <[email protected]>

* Fix typo (openhab#1244)

Signed-off-by: Wouter Born <[email protected]>

* Update persistence.md (openhab#1246)

Fixes link to quartz docs page.

* Revision. (openhab#1187) (openhab#1237)

* Revision. (openhab#1187)

- Update of screenshots, removal of old screenshots
- Chapters for better formatting
- Removal of ZWave chapter (one example of adding things should be enough IMHO)
- Adding items in simple mode and in "manual" mode

Signed-off-by: Sascha Billian <[email protected]>

* Use one line per sentence
Signed-off-by: Sascha Billian <[email protected]>

Co-authored-by: Jerome Luckenbach <[email protected]>

* Add notes for configuring Synology Diskstation (openhab#1219)

* Add notes for configuring Synology Diskstation

I have a working set up for SSL enabled remote access on a Synology diskstation, taking advantage of the GUI as much as possible, to ensure automatic renewal of certs from Let's Encrypt, etc. It took me about 8 hours to suss it all out, but it could be achieved in about 30 mins if you knew exactly what to do... may not be widely useful, but since Synology is officially supported, I figured this might be a good addition.

There's also a minor error in the 'allow' masks - these should be 192.168.0.0/24 to allow access to anything in the 192.168.0.xxx range.

* Updated to use one line per sentence

Updated to use one line per sentence - sorry for the delay!

* Update security.md

* Updated for one line per sentence

Updated for one line per sentence

Signed-off-by: Andrew Mills [email protected]

* Bad subnet (openhab#1245)

Nginx warns about low address bits of `192.168.0.1/24` because they are meaningless.
The correct subnet mask should be `192.168.0.0/24`

Signed-off-by: Olivier Béraud <[email protected]>

* Fixed broken images. (openhab#1247)

* Fixed broken images.

Signed-off-by: Jerome Luckenbach <[email protected]>

* Fix image path

Signed-off-by: Jerome Luckenbach <[email protected]>

* [documentation] clarification of representation property (openhab#1248)

* [documentation] clarification of representation property

Signed-off-by: Andrew Fiddian-Green <[email protected]>

* [documentation] typo

Signed-off-by: Andrew Fiddian-Green <[email protected]>

* [documentation] adopt suggestions of reviewers

Signed-off-by: Andrew Fiddian-Green <[email protected]>

* [documentation] commas

Signed-off-by: Andrew Fiddian-Green <[email protected]>

* [documentation] typo

Signed-off-by: Andrew Fiddian-Green <[email protected]>

* [documentation] addopted suggestions of @bobadair

Signed-off-by: Andrew Fiddian-Green <[email protected]>

* [documentation] typo

Signed-off-by: Andrew Fiddian-Green <[email protected]>

* [documentaion] example added back

Signed-off-by: Andrew Fiddian-Green <[email protected]>

* [documentaion] simplified text

Signed-off-by: Andrew Fiddian-Green <[email protected]>

* [documentation] typo

Signed-off-by: Andrew Fiddian-Green <[email protected]>

* [documentation] adopted reviewer comment

Signed-off-by: Andrew Fiddian-Green <[email protected]>

* Add Alexa mapping along side a channel mapping (openhab#1249)

* Add Alexa mapping along side a channel mapping

It took me a while to find this https://community.openhab.org/t/tagging-devices-for-alexa-support/98155/3 on the Forum and its not clearly documented in the openHAB Amazon Alexa Smart Home Skill or here in Item Metadata.
I originally suggested this as an update to the openHAB Amazon Alexa Smart Home Skill documentaion, but it fits better here, then other integrations using metadata (e.g. HomeKit or Google Assistant) could refer to it as well.

* Update items.md

* Mention defaults for element type setpoint. (openhab#1250)

Mention defaults for min, max and step value for element type setpoint.

Signed-off-by: Thomas Weiler <[email protected]>

* Update index.md (openhab#1251)

I thought 'workl' was probably intended to be 'work'.

* Items - Bedroom_Light written as Light_Bedroom (openhab#1252)

Fix small error which might mislead some readers.

* Added example for time-weighted averages (openhab#1253)

Signed-off-by: Christoph Weitkamp <[email protected]>

* Remove deprecated UIs, Eclipse Marketplace from sidebar

Signed-off-by: Yannick Schaus <[email protected]>

* Update branch name in README

Signed-off-by: Yannick Schaus <[email protected]>

Co-authored-by: Markus Storm <[email protected]>
Co-authored-by: Nagy Attila Gábor <[email protected]>
Co-authored-by: Christoph Thiede <[email protected]>
Co-authored-by: Richard Davies <[email protected]>
Co-authored-by: jwaes <[email protected]>
Co-authored-by: bracklanna <[email protected]>
Co-authored-by: Scott Rushworth <[email protected]>
Co-authored-by: cpmeister <[email protected]>
Co-authored-by: Ross Kennedy <[email protected]>
Co-authored-by: Christoph Weitkamp <[email protected]>
Co-authored-by: Skinah <[email protected]>
Co-authored-by: pali <[email protected]>
Co-authored-by: ljsquare <[email protected]>
Co-authored-by: PatrikG <[email protected]>
Co-authored-by: Elias H <[email protected]>
Co-authored-by: Billy Stevens <[email protected]>
Co-authored-by: theiding <[email protected]>
Co-authored-by: jadcx <[email protected]>
Co-authored-by: Bjorn Helgaas <[email protected]>
Co-authored-by: Jürgen Baginski <[email protected]>
Co-authored-by: robnielsen <[email protected]>
Co-authored-by: GumbyMan82 <[email protected]>
Co-authored-by: Christophe Fergeau <[email protected]>
Co-authored-by: Paulo "JCranky" Siqueira <[email protected]>
Co-authored-by: Michael Rossner <[email protected]>
Co-authored-by: BugSmurF <[email protected]>
Co-authored-by: Jerome Luckenbach <[email protected]>
Co-authored-by: josefscript <[email protected]>
Co-authored-by: Wouter Born <[email protected]>
Co-authored-by: Sami Salonen <[email protected]>
Co-authored-by: Fabian Wolter <[email protected]>
Co-authored-by: Stefan Zabka <[email protected]>
Co-authored-by: TRS-80 <[email protected]>
Co-authored-by: sihui <[email protected]>
Co-authored-by: Andrew Mills <[email protected]>
Co-authored-by: Olivier Béraud <[email protected]>
Co-authored-by: Andrew Fiddian-Green <[email protected]>
Co-authored-by: LeeC77 <[email protected]>
Co-authored-by: Thomas Weiler <[email protected]>
Co-authored-by: garretcook <[email protected]>
Co-authored-by: Michael Fielding <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@jofleck @sjsf @kaikreuzer @watou