[cloudrain] Initial contribution #11239

Tikoell · 2021-09-11T20:50:47Z

Initial contribution for a new Cloudrain binding.

Cloudrain offers a smart irrigation system which uses weather data to optimize irrigation schedules. The binding allows you to integrate, view and control Cloudrain devices in the openHAB environment with the help of the Cloudrain Developer API.

Link to the jar file
Link to the source

Signed-off-by: Till Koellmann [email protected]

Initial contribution for a Cloudrain binding (https://cloudrain.de) Signed-off-by: Till Koellmann <[email protected]> Signed-off-by: tikoell <[email protected]>

Skinah

Thanks for the submission, once you have done these I will take another look. Whilst waiting, please also go into the \target\code-analysis folder and read the report and fix anything in there.

bundles/org.openhab.binding.cloudrain/README.md

....binding.cloudrain/src/main/java/org/openhab/binding/cloudrain/internal/CloudrainConfig.java

...drain/src/main/java/org/openhab/binding/cloudrain/internal/handler/CloudrainZoneHandler.java

soenkekueper

Hey,

thanks for your contribution!

Code looks good, there are just some typos and smaller remarks.

Due this was my first code review for openhab-addons and i'm not (yet) familiar with all the things around in the
openhab-environment, i've just finished the review as comment, so feel free to skip some remarks, if they don't make sense to you.

bundles/org.openhab.binding.cloudrain/README.md

...drain/src/main/java/org/openhab/binding/cloudrain/internal/handler/CloudrainZoneHandler.java

bundles/org.openhab.binding.cloudrain/src/main/resources/OH-INF/thing/thing-types.xml

...drain/src/main/java/org/openhab/binding/cloudrain/internal/handler/CloudrainZoneHandler.java

....binding.cloudrain/src/main/java/org/openhab/binding/cloudrain/internal/CloudrainConfig.java

...loudrain/src/main/java/org/openhab/binding/cloudrain/internal/CloudrainBindingConstants.java

Tikoell · 2021-10-27T12:28:42Z

Thanks for the reviews! I will incorporate the changes by end of next week.

Signed-off-by: Till Koellmann <[email protected]>

Tikoell · 2021-11-13T18:13:03Z

Hi, thanks for the reviews. I fixed all findings and commented on your questions. Please have a look again. Thanks!

fwolter

Here comes my review feedback. @Skinah and @soenkekueper already did a good job!

bundles/org.openhab.binding.cloudrain/README.md

fwolter · 2022-01-06T20:11:37Z

bundles/org.openhab.binding.cloudrain/README.md

+| duration                  | Integer  | The total duration in seconds of an active irrigation. NULL if no irrigation is active.      |
+| remainingSeconds          | Integer  | The remaining duration in seconds of an active irrigation. NULL if no irrigation is active.  |


fwolter · 2022-01-06T21:08:37Z

...drain/src/main/java/org/openhab/binding/cloudrain/internal/handler/CloudrainZoneHandler.java

+                        // Register the zone to receive irrigation updates only if channels are linked
+                        // This is done to avoid unnecessary frequent API calls
+                        if (isAnyIrrigationChannelLinked()) {
+                            handler.registerForIrrigationUpdates(zoneId, getThing());
+                        }


You could do this more easily without retrieving the registry.

getThing().getChannels().stream().filter(channel -> isLinked(channel.getUID())).findAny().isPresent();

fwolter · 2022-01-06T21:09:22Z

...drain/src/main/java/org/openhab/binding/cloudrain/internal/handler/CloudrainZoneHandler.java

+    @Override
+    public void handleRemoval() {
+        super.handleRemoval();
+        unregisterAll();
+    }


What's the reason for implementing this method?

...drain/src/main/java/org/openhab/binding/cloudrain/internal/handler/CloudrainZoneHandler.java

fwolter · 2022-01-06T21:14:51Z

bundles/org.openhab.binding.cloudrain/src/main/resources/OH-INF/binding/binding.xml

+	xsi:schemaLocation="https://openhab.org/schemas/binding/v1.0.0 https://openhab.org/schemas/binding-1.0.0.xsd">
+
+	<name>Cloudrain Binding</name>
+	<description>This is the binding for the Cloudrain system.</description>


Could you be a bit more verbose, so that somebody who hasn't heard about it gets a clue what this is about?

This needs to be adapted to the new addon.xml, the PR to adapt the developer docs is not merged yet, so if you need more details, the corresponding issue is here: openhab/openhab-core#2058
But you can also update your branch and look at another binding's addon.xml and adapt it to this initial contribution.

bundles/org.openhab.binding.cloudrain/src/main/resources/OH-INF/thing/thing-types.xml

fwolter · 2022-06-19T15:22:47Z

@Tikoell What's the status of this PR?

wborn · 2022-07-10T08:16:46Z

bundles/org.openhab.binding.cloudrain/pom.xml

+  <parent>
+    <groupId>org.openhab.addons.bundles</groupId>
+    <artifactId>org.openhab.addons.reactor.bundles</artifactId>
+    <version>3.2.0-SNAPSHOT</version>


Suggested change

<version>3.2.0-SNAPSHOT</version>

<version>4.2.0-SNAPSHOT</version>

jlaur · 2022-12-23T15:48:43Z

bundles/org.openhab.binding.cloudrain/pom.xml

@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0"
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">


Suggested change

xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">

xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">

See #11833

lsiepel · 2023-12-24T19:30:33Z

Hi @Tikoell are you planning to proceed with this PR? it has been around here for quite some time now and i'm happy to review or help you out, but if you can't proceed, it might be better to just close this.

lsiepel · 2024-05-31T08:07:14Z

Unfortunately it looks like we cannot bring this PR to the finish line. After two years of inactivity i close this PR. If there is a need to restart, feel free to re-open or start a new PR.

Tikoell requested a review from a team as a code owner September 11, 2021 20:50

Tikoell force-pushed the cloudrain branch from 08eac0b to 063695b Compare September 11, 2021 20:53

[cloudrain] Add new binding for the Cloudrain system

440a4fb

Initial contribution for a Cloudrain binding (https://cloudrain.de) Signed-off-by: Till Koellmann <[email protected]> Signed-off-by: tikoell <[email protected]>

Tikoell force-pushed the cloudrain branch from 063695b to 440a4fb Compare September 12, 2021 14:17

Skinah added the new binding If someone has started to work on a binding. For a new binding PR. label Sep 14, 2021

Skinah requested changes Oct 3, 2021

View reviewed changes

soenkekueper reviewed Oct 25, 2021

View reviewed changes

Tikoell added 2 commits November 13, 2021 18:30

[cloudrain] Fix JUnit test

ac2ac67

Signed-off-by: Till Koellmann <[email protected]>

[cloudrain] Fix code review findings

d48a9a7

Signed-off-by: Till Koellmann <[email protected]>

Tikoell requested a review from Skinah November 14, 2021 17:54

fwolter requested changes Jan 6, 2022

View reviewed changes

wborn reviewed Jul 10, 2022

View reviewed changes

jlaur added the awaiting feedback Awaiting feedback from the pull request author label Oct 18, 2022

jlaur reviewed Dec 23, 2022

View reviewed changes

openhab deleted a comment from fwolter Jul 24, 2023

lsiepel added the stale As soon as a PR is marked stale, it can be removed 6 months later. label Apr 29, 2024

lsiepel closed this May 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cloudrain] Initial contribution #11239

[cloudrain] Initial contribution #11239

Tikoell commented Sep 11, 2021

Skinah left a comment

soenkekueper left a comment

Tikoell commented Oct 27, 2021

Tikoell commented Nov 13, 2021

fwolter left a comment

fwolter Jan 6, 2022

fwolter Jan 6, 2022

fwolter Jan 6, 2022

fwolter Jan 6, 2022

lsiepel Jan 16, 2023

fwolter commented Jun 19, 2022

wborn Jul 10, 2022 •

edited

Loading

jlaur Dec 23, 2022

lsiepel commented Dec 24, 2023

lsiepel commented May 31, 2024

		\| duration \| Integer \| The total duration in seconds of an active irrigation. NULL if no irrigation is active. \|
		\| remainingSeconds \| Integer \| The remaining duration in seconds of an active irrigation. NULL if no irrigation is active. \|

	<version>3.2.0-SNAPSHOT</version>
	<version>4.2.0-SNAPSHOT</version>

	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">

[cloudrain] Initial contribution #11239

[cloudrain] Initial contribution #11239

Conversation

Tikoell commented Sep 11, 2021

Skinah left a comment

Choose a reason for hiding this comment

soenkekueper left a comment

Choose a reason for hiding this comment

Tikoell commented Oct 27, 2021

Tikoell commented Nov 13, 2021

fwolter left a comment

Choose a reason for hiding this comment

fwolter Jan 6, 2022

Choose a reason for hiding this comment

fwolter Jan 6, 2022

Choose a reason for hiding this comment

fwolter Jan 6, 2022

Choose a reason for hiding this comment

fwolter Jan 6, 2022

Choose a reason for hiding this comment

lsiepel Jan 16, 2023

Choose a reason for hiding this comment

fwolter commented Jun 19, 2022

wborn Jul 10, 2022 • edited Loading

Choose a reason for hiding this comment

jlaur Dec 23, 2022

Choose a reason for hiding this comment

lsiepel commented Dec 24, 2023

lsiepel commented May 31, 2024

wborn Jul 10, 2022 •

edited

Loading