-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow CurrentTemperature on HomeKit Thermostat #1056
Allow CurrentTemperature on HomeKit Thermostat #1056
Conversation
In the initial implementation, characteristics and accessories had their own unique naming convention. With the ESH ontology, CurrentTemperature became both an individual accessory and a characteristic of a Thermostat. With this change, we look at the groups an item belongs to before deciding if it is an accessory or a characteristic - if a group is tagged with a recognized value, we treat the item as a characteristic. Fixes openhab#1053 Signed-off-by: Andy Lintner <[email protected]>
I tried and still is not considering the group as Thermostat. |
@Jaghova - did you build it yourself? I'm not certain on the details of when the binaries are released and distributed, but I don't think this change would be available in the normal distribution yet. If you did, can you send your .items file? |
Most probably I'm wrong, but I thought that if the PR is merged just by reinstalling the module you get the last version. |
I really don't know. Try listing the bundles and see what version it shows for the HomeKit add on? http://docs.openhab.org/administration/bundles.html |
It doesn't look like a new addons snapshot has been build since the merge. |
You can check yourself on Jenkins. |
I can confirm it now works. |
May be this is not the right place to ask it, but here it goes. I used the last snapshot by changing:
With the last distribution: Ejecute:
I see during the apt update it download files form cloudbees, but still Homekit is not working for me. Am I installing correctly the last snapshot or am I missing something? |
* master: ZWave database update (openhab#1100) ZWave database update (openhab#1098) ZWave database update (openhab#1097) ZWave database update (openhab#1096) Allow CurrentTemperature on HomeKit Thermostat (openhab#1056) Homematic: Fixed BIN-RPC reconnect with address already in use (openhab#1094) avmfritz: Fix for NPEs when trying to switch outlet. (openhab#1092) ZWave database updates (openhab#1091) ZWave fix errors in discovery logging (openhab#1088)
In the initial implementation, characteristics and accessories had their own unique naming convention. With the ESH ontology, CurrentTemperature became both an individual accessory and a characteristic of a Thermostat. With this change, we look at the groups an item belongs to before deciding if it is an accessory or a characteristic - if a group is tagged with a recognized value, we treat the item as a characteristic. Fixes openhab#1053 Signed-off-by: Andy Lintner <[email protected]>
Signed-off-by: Wouter Born <[email protected]>
In the initial implementation, characteristics and accessories had their own unique naming convention. With the ESH ontology, CurrentTemperature became both an individual accessory and a characteristic of a Thermostat.
With this change, we look at the groups an item belongs to before deciding if it is an accessory or a characteristic - if a group is tagged with a recognized value, we treat the item as a characteristic.
Fixes #1053
Signed-off-by: Andy Lintner [email protected]