Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CurrentTemperature on HomeKit Thermostat #1056

Merged
merged 1 commit into from
Jul 4, 2016

Conversation

andylintner
Copy link

In the initial implementation, characteristics and accessories had their own unique naming convention. With the ESH ontology, CurrentTemperature became both an individual accessory and a characteristic of a Thermostat.

With this change, we look at the groups an item belongs to before deciding if it is an accessory or a characteristic - if a group is tagged with a recognized value, we treat the item as a characteristic.

Fixes #1053

Signed-off-by: Andy Lintner [email protected]

In the initial implementation, characteristics and accessories had their own unique naming convention. With the ESH ontology, CurrentTemperature became both an individual accessory and a characteristic of a Thermostat.

With this change, we look at the groups an item belongs to before deciding if it is an accessory or a characteristic - if a group is tagged with a recognized value, we treat the item as a characteristic.

Fixes openhab#1053

Signed-off-by: Andy Lintner <[email protected]>
@kaikreuzer kaikreuzer merged commit 719b079 into openhab:master Jul 4, 2016
@Jaghova
Copy link

Jaghova commented Jul 4, 2016

I tried and still is not considering the group as Thermostat.

@andylintner
Copy link
Author

@Jaghova - did you build it yourself? I'm not certain on the details of when the binaries are released and distributed, but I don't think this change would be available in the normal distribution yet.

If you did, can you send your .items file?

@Jaghova
Copy link

Jaghova commented Jul 4, 2016

Most probably I'm wrong, but I thought that if the PR is merged just by reinstalling the module you get the last version.

@andylintner
Copy link
Author

I really don't know. Try listing the bundles and see what version it shows for the HomeKit add on? http://docs.openhab.org/administration/bundles.html

@rrgeorge
Copy link

rrgeorge commented Jul 4, 2016

It doesn't look like a new addons snapshot has been build since the merge.

@kaikreuzer
Copy link
Member

You can check yourself on Jenkins.
This build contains the PR: https://openhab.ci.cloudbees.com/job/openHAB2-Addons/648/
and it trigger this distro build: https://openhab.ci.cloudbees.com/job/openHAB-Distribution/392/
which finished early this morning. So indeed, if you tested yesterday, it wasn't included yet.

@rrgeorge
Copy link

rrgeorge commented Jul 5, 2016

I can confirm it now works.

@Jaghova
Copy link

Jaghova commented Jul 6, 2016

May be this is not the right place to ask it, but here it goes.

I used the last snapshot by changing:

/etc/apt/sources.list.d/openhab.list

With the last distribution:

deb https://openhab.ci.cloudbees.com/job/openHAB-Distribution/ws/distributions/openhab-offline/target/apt-repo/ /

Ejecute:

apt-get update && apt-get upgrade

I see during the apt update it download files form cloudbees, but still Homekit is not working for me.

Am I installing correctly the last snapshot or am I missing something?

cdjackson added a commit to cdjackson/openhab2-addons that referenced this pull request Jul 9, 2016
* master:
  ZWave database update (openhab#1100)
  ZWave database update (openhab#1098)
  ZWave database update (openhab#1097)
  ZWave database update (openhab#1096)
  Allow CurrentTemperature on HomeKit Thermostat (openhab#1056)
  Homematic: Fixed BIN-RPC reconnect with address already in use (openhab#1094)
  avmfritz: Fix for NPEs when trying to switch outlet. (openhab#1092)
  ZWave database updates (openhab#1091)
  ZWave fix errors in discovery logging (openhab#1088)
doubled-ca pushed a commit to doubled-ca/openhab-addons that referenced this pull request Aug 14, 2016
In the initial implementation, characteristics and accessories had their own unique naming convention. With the ESH ontology, CurrentTemperature became both an individual accessory and a characteristic of a Thermostat.

With this change, we look at the groups an item belongs to before deciding if it is an accessory or a characteristic - if a group is tagged with a recognized value, we treat the item as a characteristic.

Fixes openhab#1053

Signed-off-by: Andy Lintner <[email protected]>
@kaikreuzer kaikreuzer modified the milestone: 2.0.0 Jan 17, 2017
@wborn wborn added the homekit label Dec 16, 2018
Flole998 pushed a commit to Flole998/openhab-addons that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants