Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAX! Update for new xsd definitions #105

Merged
merged 2 commits into from
Jan 13, 2015
Merged

Conversation

marcelrv
Copy link
Contributor

@marcelrv marcelrv commented Jan 7, 2015

Also includes:
Set boost needs a setpoint temperature #1821
(openhab/openhab1-addons#1821) alternative approach
simplifying the code, eliminating the need for PR #82

new lines at end of all files as suggested by Thomas.

Signed-off-by: marcel [email protected]

Also includes:
Set boost needs a setpoint temperature openhab#1821
(openhab/openhab1-addons#1821) alternative approach
simplifying the code.

new lines at end of all files as suggested by Thomas.

Signed-off-by: marcel <[email protected]>
@kaikreuzer
Copy link
Member

Great, nice to see the XML extensions being used so quickly!
There is just one thing I wonder: Whether it makes sense to have the "max" tag on the channels - what is the idea behind it?
I know we are lacking any kind of guideline on how tags should be used (and we will also have to come up with some default tag library) - so no offence at all.

@marcelrv
Copy link
Contributor Author

marcelrv commented Jan 7, 2015

Well,

The thinking behind it was that it would be nice to have all the items
related to the max system in one screen. Hence the max tag.
I made all the regular heating stuff (mode, set temp and actual temp) as
heating reflecting the basic items for the heating system.

I assume we will later in the UI be able to group stuff by the tag

Also I want to see if I can dynamically add tags later onwards, as I would
like to tag with the room names (coming from the max cube definitions) as
well.

2015-01-07 23:08 GMT+01:00 Kai Kreuzer [email protected]:

Great, nice to see the XML extensions being used so quickly!
There is just one thing I wonder: Whether it makes sense to have the "max"
tag on the channels - what is the idea behind it?
I know we are lacking any kind of guideline on how tags should be used
(and we will also have to come up with some default tag library) - so no
offence at all.


Reply to this email directly or view it on GitHub
#105 (comment).

@kaikreuzer
Copy link
Member

The thinking behind it was that it would be nice to have all the items
related to the max system in one screen. Hence the max tag.

Hm, if this would be a best practice", we could actually adapt the thing infrastructure to add such tags automatically for items - so even in this case there is no need to have them specified here. I would therefore suggest to remove them!

@kaikreuzer
Copy link
Member

Besides this, this PR is ready for merging.

replaced some maxcube reference to MAX!


Signed-off-by: Marcel Verpaalen <[email protected]>
@marcelrv
Copy link
Contributor Author

Okay removed the max tag.

@kaikreuzer
Copy link
Member

Thanks!

kaikreuzer added a commit that referenced this pull request Jan 13, 2015
MAX! Update for new xsd definitions
@kaikreuzer kaikreuzer merged commit 90e4046 into openhab:master Jan 13, 2015
@kaikreuzer kaikreuzer modified the milestone: 2.0.0 alpha2 Apr 4, 2015
VelinYordanov added a commit to MusalaSoft/openhab2-addons that referenced this pull request Jul 14, 2017
…hab.binding.zoneminder.

See openhab/static-code-analysis openhab#105.

Signed off by Velin Yordanov [email protected]
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Mar 29, 2019
Fixed pattern for low and high, fixed typo in low channel definition.
Flole998 pushed a commit to Flole998/openhab-addons that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants