-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAX! Update for new xsd definitions #105
Conversation
Also includes: Set boost needs a setpoint temperature openhab#1821 (openhab/openhab1-addons#1821) alternative approach simplifying the code. new lines at end of all files as suggested by Thomas. Signed-off-by: marcel <[email protected]>
Great, nice to see the XML extensions being used so quickly! |
Well, The thinking behind it was that it would be nice to have all the items I assume we will later in the UI be able to group stuff by the tag Also I want to see if I can dynamically add tags later onwards, as I would 2015-01-07 23:08 GMT+01:00 Kai Kreuzer [email protected]:
|
Hm, if this would be a best practice", we could actually adapt the thing infrastructure to add such tags automatically for items - so even in this case there is no need to have them specified here. I would therefore suggest to remove them! |
Besides this, this PR is ready for merging. |
replaced some maxcube reference to MAX! Signed-off-by: Marcel Verpaalen <[email protected]>
Okay removed the max tag. |
Thanks! |
MAX! Update for new xsd definitions
…hab.binding.zoneminder. See openhab/static-code-analysis openhab#105. Signed off by Velin Yordanov [email protected]
Fixed pattern for low and high, fixed typo in low channel definition.
Signed-off-by: Kai Kreuzer <[email protected]>
Also includes:
Set boost needs a setpoint temperature #1821
(openhab/openhab1-addons#1821) alternative approach
simplifying the code, eliminating the need for PR #82
new lines at end of all files as suggested by Thomas.
Signed-off-by: marcel [email protected]