Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ipcamera] Improve Dahua alarms #10078

Merged
merged 10 commits into from
Feb 24, 2021
Merged

[ipcamera] Improve Dahua alarms #10078

merged 10 commits into from
Feb 24, 2021

Conversation

Skinah
Copy link
Contributor

@Skinah Skinah commented Feb 6, 2021 •
edited
Loading

These changes will:

  • Add a number of new alarm channels for Dahua and has cleaned up the handling of alarms to make them easier to maintain and extend. [ipcamera] Support for SMD Plus for Dahua XVR with AI #9129
  • Change scheduleAtFixedRate() to scheduleWithFixedDelay() as requested by @fwolter .
  • Slight change to Digest auths to bring it closer to how CURL handles a digest string. Does not fix any known issues but may help with compatibility.
  • Fix: HLS was not using new output folders and other options until a restart of binding was done. Reported by user on forum.
  • Fix: Some Foscam cameras were not getting detected as Foscam and would get added to inbox as generic onvif.

Signed-off-by: Matthew Skinner [email protected]

Skinah added 4 commits February 3, 2021 18:20
@Skinah
Add more alarms to Dahua.
ad98d9d 
Signed-off-by: Matthew Skinner <[email protected]>
@Skinah
Spotless
8e8e469 
Signed-off-by: Matthew Skinner <[email protected]>
@Skinah
HLS fix.
37eb05e 
Signed-off-by: Matthew Skinner <[email protected]>
@Skinah
Doorbird optimize
0b5c11a 
Signed-off-by: Matthew Skinner <[email protected]>
@Skinah Skinah linked an issue Feb 6, 2021 that may be closed by this pull request
[ipcamera] Support for SMD Plus for Dahua XVR with AI #9129
Closed
@Skinah Skinah added bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on labels Feb 6, 2021
@Skinah
Reduce logging.
e86e176 
Signed-off-by: Matthew Skinner <[email protected]>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/ipcamera-new-ip-camera-binding/42771/2296

Skinah and others added 3 commits February 24, 2021 18:08
@Skinah @fwolter
Update bundles/org.openhab.binding.ipcamera/src/main/java/org/openhab…
511055e 
…/binding/ipcamera/internal/DahuaHandler.java


Signed-off-by: Matthew Skinner <[email protected]>

Co-authored-by: Fabian Wolter <[email protected]>
@Skinah @fwolter
Update bundles/org.openhab.binding.ipcamera/src/main/java/org/openhab…
d5e11cc 
…/binding/ipcamera/internal/DahuaHandler.java


Signed-off-by: Matthew Skinner <[email protected]>

Co-authored-by: Fabian Wolter <[email protected]>
@Skinah
Add checks for indexOf not finding string.
00b78eb 
Signed-off-by: Matthew Skinner <[email protected]>
@Skinah
Copy link
Contributor Author

Skinah commented Feb 24, 2021

@fwolter Thanks for looking it over, all requested changes have been made.

fwolter
fwolter approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fwolter fwolter merged commit 6b624f0 into openhab:main Feb 24, 2021
@fwolter fwolter added this to the 3.1 milestone Feb 24, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@Skinah @themillhousegroup
[ipcamera] Improve Dahua alarms (openhab#10078)
f1f8513 
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: John Marshall <[email protected]>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@Skinah @computergeek1507
[ipcamera] Improve Dahua alarms (openhab#10078)
3794220 
Signed-off-by: Matthew Skinner <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@Skinah @thinkingstone
[ipcamera] Improve Dahua alarms (openhab#10078)
fe6d86f 
Signed-off-by: Matthew Skinner <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@Skinah
[ipcamera] Improve Dahua alarms (openhab#10078)
3926872 
Signed-off-by: Matthew Skinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwolter fwolter fwolter approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

[ipcamera] Support for SMD Plus for Dahua XVR with AI
3 participants
@Skinah @openhab-bot @fwolter