Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lgwebos] Enhancing the modelName property #7119

Closed
lolodomo opened this issue Mar 8, 2020 · 0 comments · Fixed by #7385
Closed

[lgwebos] Enhancing the modelName property #7119

lolodomo opened this issue Mar 8, 2020 · 0 comments · Fixed by #7385
Assignees
@lolodomo
Labels
enhancement An enhancement or new feature for an existing add-on

Comments

@lolodomo
Copy link
Contributor

lolodomo commented Mar 8, 2020

A really minor enhancement would be to concatene "Model Name" and "Model Number" found by UPnP to set the thing property "modelName". Only "Model Name" is used until now which leads for my TV to this value "LG Smart TV" which is not really a model.

I will propose a fix.
@lolodomo lolodomo added bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on and removed bug An unexpected problem or unintended behavior of an add-on labels Mar 8, 2020
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Mar 8, 2020
@lolodomo
[lgwebos] Detection of power on/off with UPnP
2675a80 
Also fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo mentioned this issue Mar 8, 2020
Closed
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Mar 8, 2020
@lolodomo
[lgwebos] Detection of power on/off with UPnP
6eeb0f1 
Also fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Mar 11, 2020
@lolodomo
[lgwebos] Detection of power on/off with UPnP
6d84479 
Aso fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Mar 11, 2020
@lolodomo
[lgwebos] Detection of power on/off with UPnP
69adaed 
Aso fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Mar 14, 2020
@lolodomo
[lgwebos] Detection of power on/off with UPnP
d84ae46 
Also fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Mar 15, 2020
@lolodomo
[lgwebos] Detection of power on/off with UPnP
24c0893 
Also fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Mar 21, 2020
@lolodomo
[lgwebos] Detection of power on/off with UPnP
8bde76d 
Also fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Apr 5, 2020
@lolodomo
[lgwebos] Detection of power on/off with UPnP
b82002c 
Also fix openhab#7119
Ignore messages when the thing handler is already disposed

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Apr 10, 2020
@lolodomo
[lgwebos] Detection of power on/off with UPnP
6c1d7df 
Also fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Apr 10, 2020
@lolodomo
[lgwebos] Detection of power on/off with UPnP
c884e1b 
Also fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Apr 16, 2020
@lolodomo
[lgwebos] Fix property modelName
edcf9b3 
Fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo mentioned this issue Apr 16, 2020
Merged
cpmeister pushed a commit that referenced this issue Apr 16, 2020
@lolodomo
[lgwebos] Fix property modelName (#7385)
9ac072d 
Fix #7119

Signed-off-by: Laurent Garnier <[email protected]>
yfre pushed a commit to yfre/openhab-addons that referenced this issue Apr 27, 2020
@lolodomo
[lgwebos] Fix property modelName (openhab#7385)
3c480a7 
Fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this issue May 29, 2020
@lolodomo @markus7017
[lgwebos] Fix property modelName (openhab#7385)
889ee3b 
Fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this issue Jun 8, 2020
@lolodomo @LoungeFlyZ
[lgwebos] Fix property modelName (openhab#7385)
fbaeacf 
Fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this issue Jul 14, 2020
@lolodomo @J-N-K
[lgwebos] Fix property modelName (openhab#7385)
83ddc2a 
Fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this issue Jul 26, 2020
@lolodomo @CSchlipp
[lgwebos] Fix property modelName (openhab#7385)
672f596 
Fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@lolodomo @andrewfg
[lgwebos] Fix property modelName (openhab#7385)
48427c5 
Fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@lolodomo @andrewfg
[lgwebos] Fix property modelName (openhab#7385)
c6722c3 
Fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@lolodomo @andrewfg
[lgwebos] Fix property modelName (openhab#7385)
1ecf2ec 
Fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@lolodomo @andrewfg
[lgwebos] Fix property modelName (openhab#7385)
c353200 
Fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this issue Sep 1, 2020
@lolodomo @DaanMeijer
[lgwebos] Fix property modelName (openhab#7385)
e72da25 
Fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this issue Sep 19, 2020
@lolodomo @markus7017
[lgwebos] Fix property modelName (openhab#7385)
db8c203 
Fix openhab#7119

Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lolodomo lolodomo

Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
No milestone
1 participant
@lolodomo