[marytts] StringIndexOutOfBoundsException when using Java 9/10/11 #3953
Labels
infrastructure
Build system and Karaf related issues and PRs
Comments
|
To test the fix I've created a new org.openhab.voice.marytts-2.4.0-SNAPSHOT.jar using the latest MaryTTS master. The fix works and besides adding library dependency changes no further code changes were necessary. Maybe you also want to use and test it @BClark09? The master is hopefully merged into the 5.x branch and released as MaryTTS 5.3 in the coming weeks. The only issue is that the library dependency changes significantly increase the (already big) bundle size from 22.3 MB to 35.6 MB. 😢 That is mainly due to the new required dependencies:
I tried removing them but it results in ClassNotFoundExceptions. |
|
It should at least be possible to remove parts of groovy-all, because this bundles all its dependencies. Wrt icu, I somehow had in mind that there is a minimized drop-in replacement that is also used in Eclipse. Would be worth to dig a bit deeper to reduce the deps size... |
|
It doesn't seem to work for me, but I'm not sure if this is a configuration issue. On boot I get the warnings: Then when I try to |
|
@wborn I wanted to test the new Mary TTS version today. But falsely I uninstalled the voice add-on in my live environment. After I realized what I had done I wanted to reinstall the latest 2.4.0.M4 version of the add-on via PaperUI. I got the same error as reported by @BClark09 . I have the slight feeling that this issue was introduced with #3840 (see MaryTTSService.java). Wdyt? |
|
Did you also try restarting openHAB? IIRC when I was testing it wouldn't properly initialize when using the |
|
Hm, a restart did the trick. Now it is working again in my live environment. Thanks. But to be honest not very satisfying. Can we represent this in front of the community? Any ideas how we can solve this? |
|
I rather wouldn't have this issue ofcourse. But it may already have been an issue in 2.3.0. I don't remember if I already checked it. I do remember it was very frustrating to find out that a restart solved it. 😑 |
|
I do not want to blame you for this. I think I have an idea. Will do some tests and maybe come up with a PR later. Good news are: The new version is working for me like a charm on OH2.4.0.M4 - of course after a restart. |
|
I tried restarting it and still get stuck with the error: I've tried updating my locale again to en_GB but with no luck. |
wborn
changed the title
davidgraeff
added
the
infrastructure
|
I'm closing this issue because I found out while working on https://github.com/openhab/openhab2-addons/pull/6482 that older MaryTTS versions do work with GA Java 11 releases. In GA releases the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The MaryTTS voice add-on fails to start when used with Java 9/10/11.
The following exceptions are logged for this:
To support Java 11 (openhab/openhab-distro#768) we need to upgrade the MaryTTS libraries to a version that includes the fix for marytts/marytts#783.
There is currently no released MaryTTS version that contains this fix.
The fix is to completely remove the version check (marytts/marytts@4aada82).
As a workaround we could also create our own fork to apply this fix.
The text was updated successfully, but these errors were encountered: