Applied feedback from Hilbrand (few minor things)

Signed-off-by: Giovanni Mirulla <[email protected]>
openhab · Sep 6, 2020 · 9e79a63 · 9e79a63
1 parent bd8046e
commit 9e79a63
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 10 deletions.
diff --git a/CODEOWNERS b/CODEOWNERS
@@ -8,7 +8,7 @@
 /bundles/org.openhab.binding.adorne/ @theiding
 /bundles/org.openhab.binding.airquality/ @kubawolanin
 /bundles/org.openhab.binding.airvisualnode/ @3cky
-/bundles/org.openhab.binding.alarmdecoder/ @bobadair @billfor @berndpfrommer
+/bundles/org.openhab.binding.alarmdecoder/ @bobadair @billfor
 /bundles/org.openhab.binding.allplay/ @dominicdesu
 /bundles/org.openhab.binding.amazondashbutton/ @OLibutzki
 /bundles/org.openhab.binding.amazonechocontrol/ @mgeramb
@@ -34,6 +34,7 @@
 /bundles/org.openhab.binding.caddx/ @jossuar
 /bundles/org.openhab.binding.chromecast/ @kaikreuzer
 /bundles/org.openhab.binding.cm11a/ @BobRak
+/bundles/org.openhab.binding.comfoair/ @boehan
 /bundles/org.openhab.binding.coolmasternet/ @projectgus
 /bundles/org.openhab.binding.coronastats/ @DerOetzi
 /bundles/org.openhab.binding.daikin/ @caffineehacker
@@ -46,6 +47,7 @@
 /bundles/org.openhab.binding.dlinksmarthome/ @MikeJMajor
 /bundles/org.openhab.binding.dmx/ @J-N-K
 /bundles/org.openhab.binding.doorbird/ @mhilbush
+/bundles/org.openhab.binding.draytonwiser/ @andrew-schofield
 /bundles/org.openhab.binding.dscalarm/ @RSStephens
 /bundles/org.openhab.binding.dsmr/ @Hilbrand
 /bundles/org.openhab.binding.ecobee/ @mhilbush
@@ -126,8 +128,11 @@
 /bundles/org.openhab.binding.milight/ @davidgraeff
 /bundles/org.openhab.binding.minecraft/ @ibaton
 /bundles/org.openhab.binding.modbus/ @ssalonen
+/bundles/org.openhab.binding.modbus.e3dc/ @weymann
 /bundles/org.openhab.binding.modbus.studer/ @giovannimirulla
 /bundles/org.openhab.binding.modbus.sunspec/ @mrbig
+/bundles/org.openhab.binding.modbus.stiebeleltron/ @pail23
+/bundles/org.openhab.binding.monopriceaudio/ @mlobstein
 /bundles/org.openhab.binding.mqtt/ @davidgraeff
 /bundles/org.openhab.binding.mqtt.generic/ @davidgraeff
 /bundles/org.openhab.binding.mqtt.homeassistant/ @davidgraeff
@@ -147,6 +152,7 @@
 /bundles/org.openhab.binding.novafinedust/ @t2000
 /bundles/org.openhab.binding.ntp/ @marcelrv
 /bundles/org.openhab.binding.nuki/ @mkatter
+/bundles/org.openhab.binding.nuvo/ @mlobstein
 /bundles/org.openhab.binding.oceanic/ @kgoderis
 /bundles/org.openhab.binding.ojelectronics/ @EvilPingu
 /bundles/org.openhab.binding.omnikinverter/ @hansbogert
@@ -159,6 +165,8 @@
 /bundles/org.openhab.binding.openthermgateway/ @ArjenKorevaar
 /bundles/org.openhab.binding.openuv/ @clinique
 /bundles/org.openhab.binding.openweathermap/ @cweitkamp
+/bundles/org.openhab.binding.openwebnet/ @mvalla
+/bundles/org.openhab.binding.oppo/ @mlobstein
 /bundles/org.openhab.binding.orvibo/ @tavalin
 /bundles/org.openhab.binding.paradoxalarm/ @theater
 /bundles/org.openhab.binding.pentair/ @jsjames
@@ -204,6 +212,7 @@
 /bundles/org.openhab.binding.sonyprojector/ @lolodomo
 /bundles/org.openhab.binding.spotify/ @Hilbrand
 /bundles/org.openhab.binding.squeezebox/ @digitaldan @mhilbush
+/bundles/org.openhab.binding.mpd/ @stefanroellin
 /bundles/org.openhab.binding.synopanalyzer/ @clinique
 /bundles/org.openhab.binding.systeminfo/ @svilenvul
 /bundles/org.openhab.binding.tado/ @dfrommi
@@ -215,6 +224,7 @@
 /bundles/org.openhab.binding.tplinksmarthome/ @Hilbrand
 /bundles/org.openhab.binding.tradfri/ @cweitkamp @kaikreuzer
 /bundles/org.openhab.binding.unifi/ @mgbowman
+/bundles/org.openhab.binding.upnpcontrol/ @mherwege
 /bundles/org.openhab.binding.urtsi/ @OLibutzki
 /bundles/org.openhab.binding.valloxmv/ @bjoernbrings
 /bundles/org.openhab.binding.vektiva/ @octa22

diff --git a/...modbus.studer/src/main/java/org/openhab/binding/modbus/studer/internal/StuderHandler.java b/...modbus.studer/src/main/java/org/openhab/binding/modbus/studer/internal/StuderHandler.java
@@ -439,4 +439,4 @@ protected void resetCommunicationError() {
             updateStatus(ThingStatus.ONLINE);
         }
     }
-}
+}
diff --git a/bundles/org.openhab.binding.modbus.studer/src/main/resources/ESH-INF/thing/thing-types.xml b/bundles/org.openhab.binding.modbus.studer/src/main/resources/ESH-INF/thing/thing-types.xml
@@ -23,7 +23,7 @@
 				<description>Slave address of BSP device</description>
 				<default>60</default>
 			</parameter>
-			<parameter name="refreshSec" type="integer" min="1" unit="s">
+			<parameter name="refresh" type="integer" min="1" unit="s">
 				<label>Refresh Interval</label>
 				<description>Poll interval</description>
 				<default>5</default>
@@ -56,11 +56,11 @@
 				<description>Slave address of Xtender device</description>
 				<default>10</default>
 			</parameter>
-			<parameter name="refreshSec" type="integer" min="1" unit="s">
+			<parameter name="refresh" type="integer" min="1" unit="s">
 				<label>Refresh Interval</label>
 				<description>Poll interval</description>
 				<default>5</default>
-                <advanced>true</advanced>
+				<advanced>true</advanced>
 			</parameter>
 		</config-description>
 	</thing-type>
@@ -87,7 +87,7 @@
 				<description>Slave address of VarioTrack device</description>
 				<default>20</default>
 			</parameter>
-			<parameter name="refreshSec" type="integer" min="1" unit="s">
+			<parameter name="refresh" type="integer" min="1" unit="s">
 				<label>Refresh Interval</label>
 				<description>Poll interval</description>
 				<default>5</default>
@@ -128,7 +128,7 @@
 				<description>Slave address of VarioString device</description>
 				<default>40</default>
 			</parameter>
-			<parameter name="refreshSec" type="integer" min="1" unit="s">
+			<parameter name="refresh" type="integer" min="1" unit="s">
 				<label>Refresh Interval</label>
 				<description>Poll interval</description>
 				<default>5</default>

diff --git a/bundles/pom.xml b/bundles/pom.xml
@@ -7,7 +7,7 @@
   <parent>
     <groupId>org.openhab.addons</groupId>
     <artifactId>org.openhab.addons.reactor</artifactId>
-    <version>2.5.7-SNAPSHOT</version>
+    <version>2.5.9-SNAPSHOT</version>
   </parent>
 
   <groupId>org.openhab.addons.bundles</groupId>
@@ -69,6 +69,7 @@
     <module>org.openhab.binding.cbus</module>
     <module>org.openhab.binding.chromecast</module>
     <module>org.openhab.binding.cm11a</module>
+    <module>org.openhab.binding.comfoair</module>
     <module>org.openhab.binding.coolmasternet</module>
     <module>org.openhab.binding.coronastats</module>
     <module>org.openhab.binding.daikin</module>
@@ -81,6 +82,7 @@
     <module>org.openhab.binding.dlinksmarthome</module>
     <module>org.openhab.binding.dmx</module>
     <module>org.openhab.binding.doorbird</module>
+    <module>org.openhab.binding.draytonwiser</module>
     <module>org.openhab.binding.dscalarm</module>
     <module>org.openhab.binding.dsmr</module>
     <module>org.openhab.binding.dwdpollenflug</module>
@@ -120,6 +122,7 @@
     <module>org.openhab.binding.hue</module>
     <module>org.openhab.binding.hydrawise</module>
     <module>org.openhab.binding.hyperion</module>
+    <module>org.openhab.binding.iammeter</module>
     <module>org.openhab.binding.iaqualink</module>
     <module>org.openhab.binding.icalendar</module>
     <module>org.openhab.binding.icloud</module>
@@ -162,8 +165,12 @@
     <module>org.openhab.binding.milight</module>
     <module>org.openhab.binding.minecraft</module>
     <module>org.openhab.binding.modbus</module>
-    <module>org.openhab.binding.modbus.studer</module>    
+    <module>org.openhab.binding.modbus.e3dc</module>
+    <module>org.openhab.binding.modbus.studer</module>   
     <module>org.openhab.binding.modbus.sunspec</module>
+    <module>org.openhab.binding.modbus.stiebeleltron</module>
+    <module>org.openhab.binding.monopriceaudio</module>
+    <module>org.openhab.binding.mpd</module>
     <module>org.openhab.binding.mqtt</module>
     <module>org.openhab.binding.mqtt.generic</module>
     <module>org.openhab.binding.mqtt.homeassistant</module>
@@ -183,6 +190,7 @@
     <module>org.openhab.binding.novafinedust</module>
     <module>org.openhab.binding.ntp</module>
     <module>org.openhab.binding.nuki</module>
+    <module>org.openhab.binding.nuvo</module>
     <module>org.openhab.binding.oceanic</module>
     <module>org.openhab.binding.ojelectronics</module>
     <module>org.openhab.binding.omnikinverter</module>
@@ -195,6 +203,8 @@
     <module>org.openhab.binding.openthermgateway</module>
     <module>org.openhab.binding.openuv</module>
     <module>org.openhab.binding.openweathermap</module>
+    <module>org.openhab.binding.openwebnet</module>
+    <module>org.openhab.binding.oppo</module>
     <module>org.openhab.binding.orvibo</module>
     <module>org.openhab.binding.paradoxalarm</module>
     <module>org.openhab.binding.pentair</module>
@@ -233,7 +243,7 @@
     <module>org.openhab.binding.snmp</module>
     <module>org.openhab.binding.solaredge</module>
     <module>org.openhab.binding.solarlog</module>
-	<module>org.openhab.binding.somfymylink</module>
+    <module>org.openhab.binding.somfymylink</module>
     <module>org.openhab.binding.somfytahoma</module>
     <module>org.openhab.binding.sonos</module>
     <module>org.openhab.binding.sonyaudio</module>
@@ -251,6 +261,7 @@
     <module>org.openhab.binding.tplinksmarthome</module>
     <module>org.openhab.binding.tradfri</module>
     <module>org.openhab.binding.unifi</module>
+    <module>org.openhab.binding.upnpcontrol</module>
     <module>org.openhab.binding.urtsi</module>
     <module>org.openhab.binding.valloxmv</module>
     <module>org.openhab.binding.vektiva</module>
-Original file line number
+Diff line change
@@ Expand Up / @@ -439,4 +439,4 @@ protected void resetCommunicationError() { @@
                 updateStatus(ThingStatus.ONLINE);
             }
         }
-    }
+    }