Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show index page #992

Merged
merged 4 commits into from
Jan 24, 2025
Merged

fix: show index page #992

merged 4 commits into from
Jan 24, 2025

Conversation

seaerchin
Copy link
Contributor

Problem

index pages display in the sidebar but not in the main view - we should not be showing such index pages for reasons outlined here

Solution

  1. update typing using Exclude in router method
  2. add filter for IndexPage

Tests

  1. add a custom index page in db
  2. verify that this cannot be seenin the sidebar

@seaerchin seaerchin requested a review from a team as a code owner January 15, 2025 09:15
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Jan 15, 2025

Datadog Report

Branch report: fix/hide-index
Commit report: 8159540
Test service: isomer-studio

✅ 0 Failed, 257 Passed, 36 Skipped, 45.13s Total Time
➡️ Test Sessions change in coverage: 1 no change

@seaerchin seaerchin changed the title fix: hide index page fix: show index page Jan 21, 2025
@seaerchin seaerchin enabled auto-merge (squash) January 21, 2025 08:43
@seaerchin seaerchin disabled auto-merge January 22, 2025 08:11
@seaerchin seaerchin enabled auto-merge (squash) January 22, 2025 08:11
@seaerchin seaerchin disabled auto-merge January 24, 2025 08:59
@seaerchin seaerchin merged commit 507da67 into main Jan 24, 2025
16 of 17 checks passed
@seaerchin seaerchin deleted the fix/hide-index branch January 24, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants