Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vica hydration bug #1018

Merged
merged 2 commits into from
Jan 26, 2025
+18 −13
Merged

Fix vica hydration bug #1018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96921d1
split into 2 files
adriangohjw Jan 23, 2025
f18a82f
add "use client" + not SSG
adriangohjw Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/components/src/templates/next/components/internal/Vica/VicaStylesheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
export const VicaStylesheet = () => {
return (
<>
<link
href="https://webchat.vica.gov.sg/static/css/chat.css"
referrerPolicy="origin"
rel="stylesheet"
/>
</>
)
}
17 changes: 5 additions & 12 deletions ...es/next/components/internal/Vica/Vica.tsx → ...t/components/internal/Vica/VicaWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,14 @@
import type { VicaProps } from "~/interfaces"
"use client"

export const VicaStylesheet = () => {
return (
<>
<link
href="https://webchat.vica.gov.sg/static/css/chat.css"
referrerPolicy="origin"
rel="stylesheet"
/>
</>
)
}
import type { VicaProps } from "~/interfaces"

export const VicaWidget = ({
ScriptComponent = "script",
...props
}: VicaProps) => {
// to not render during static site generation on the server
if (typeof window === "undefined") return null

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: prefer !window

return (
<>
<ScriptComponent
Expand Down
3 changes: 2 additions & 1 deletion packages/components/src/templates/next/components/internal/Vica/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
export * from "./Vica"
export * from "./VicaWidget"
export * from "./VicaStylesheet"
Loading