docs(BlogCard, CollectionCard): Update TODO comment for external link…

… icon placement
opengovsg · Feb 25, 2025 · 4cf732c · 4cf732c
1 parent e1fdb2d
commit 4cf732c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/packages/components/src/templates/next/components/internal/BlogCard/BlogCard.stories.tsx b/packages/components/src/templates/next/components/internal/BlogCard/BlogCard.stories.tsx
@@ -81,11 +81,11 @@ export const ExternalLink: Story = {
   }),
 }
 
-// TODO: fix external link icon not visible when the text is being truncated
-// because the icon is at the end of the text
-// export const ExternalLinkLongText: Story = {
-//   args: generateArgs({ isExternalLink: true }),
-// }
+// TODO: ideally when the text is being truncated,
+// the external link icon should be at the end of the text instead of the newline
+export const ExternalLinkLongText: Story = {
+  args: generateArgs({ isExternalLink: true }),
+}
 
 export const UndefinedDate: Story = {
   args: generateArgs({ isLastUpdatedUndefined: true }),

diff --git a/...mponents/src/templates/next/components/internal/CollectionCard/CollectionCard.stories.tsx b/...mponents/src/templates/next/components/internal/CollectionCard/CollectionCard.stories.tsx
@@ -80,11 +80,11 @@ export const ExternalLink: Story = {
   }),
 }
 
-// TODO: fix external link icon not visible when the text is being truncated
-// because the icon is at the end of the text
-// export const ExternalLinkLongText: Story = {
-//   args: generateArgs({ isExternalLink: true }),
-// }
+// TODO: ideally when the text is being truncated,
+// the external link icon should be at the end of the text instead of the newline
+export const ExternalLinkLongText: Story = {
+  args: generateArgs({ isExternalLink: true }),
+}
 
 export const UndefinedDate: Story = {
   args: generateArgs({ isLastUpdatedUndefined: true }),