Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update links to SMIRNOFF spec from deleted topology branch #198

Merged
merged 2 commits into from
Apr 27, 2020
Merged

Update links to SMIRNOFF spec from deleted topology branch #198

merged 2 commits into from
Apr 27, 2020

Conversation

jchodera
Copy link
Member

Fixes #184

This was referenced Oct 19, 2019
Closed
Open
j-wags
j-wags approved these changes Oct 19, 2019
View reviewed changes
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You could point to the 0.2.0 docs on RTD if you don't want to link to a commit.

content/news/rdkit-support-is-coming.md Outdated

### New openforcefield `Molecule` and `Topology` objects

Specifying the system to parameterize with [SMIRNOFF](https://open-forcefield-toolkit.readthedocs.io/en/topology/smirnoff.html) previously required passing along a set of OpenEye Toolkit [`OEMol`](https://docs.eyesopen.com/toolkits/python/oechemtk/OEChemClasses/OEMol.html) objects.
Specifying the system to parameterize with [SMIRNOFF](https://github.com/openforcefield/openforcefield/blob/e3606e3aa2aefa14123e6179b6ece1cd35cf8f50/The-SMIRNOFF-force-field-format.md) previously required passing along a set of OpenEye Toolkit [`OEMol`](https://docs.eyesopen.com/toolkits/python/oechemtk/OEChemClasses/OEMol.html) objects.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We keep legacy version of the docs around. How about https://open-forcefield-toolkit.readthedocs.io/en/0.2.0/smirnoff.html instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@jchodera
Copy link
Member Author

At @j-wags suggestion, I've updated the SMIRNOFF 0.2 links to https://open-forcefield-toolkit.readthedocs.io/en/0.2.0/smirnoff.html

@j-wags j-wags merged commit b9dfb5a into master Apr 27, 2020
@j-wags j-wags deleted the fix-smirnoff-links branch April 27, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags j-wags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad SMIRNOFF links
2 participants
@jchodera @j-wags