Support Pint 0.24.4 / openff-units 0.3.0
#1990
Merged
+76
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
14 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Closed
|
These changes seem backwards-compatible, i.e. a release with this patch should work on 0.2.0 through 0.3.0 versions of the units package |
mattwthompson
changed the title
openff-units 0.3.0
Closed
mattwthompson
commented
Feb 7, 2025
mattwthompson
commented
Feb 7, 2025
| matrix: | ||
| os: [ubuntu-latest, macos-latest] | ||
| python-version: ["3.10", "3.11", "3.12"] | ||
| rdkit: [true, false] | ||
| openeye: [true, false] | ||
| new-pint: [false, true] |
There was a problem hiding this comment.
Everything touching this variable could be dropped before merge, but I think it's important to show changes with "new" and existing versions of the upsreams
j-wags
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Looks good, thanks @mattwthompson. One small request to document a super obscure behavior change in the releasehistory, otherwise this is good to go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With openforcefield/openff-units#104
mypy =0.15