Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard toolkit imports #61

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Guard toolkit imports #61

merged 2 commits into from
Sep 8, 2023

Conversation

lilyminium
Copy link
Collaborator

Fixes #56

Changes made in this Pull Request:

  • Guard toolkit imports

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2023 •
edited
Loading

Codecov Report

Merging #61 (75a3ba4) into main (707926f) will decrease coverage by 0.08%.
The diff coverage is 83.33%.

Additional details and impacted files
📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openforcefield).

@lilyminium
Copy link
Collaborator Author

lilyminium commented Sep 8, 2023 •
edited
Loading

Sorry @mattwthompson -- in my development environment it's a bit more convenient if I can have the _NAGLToolkitWrapper in the GLOBAL_TOOLKIT_REGISTRY, so I added guards to the imports separately so it could work.

@lilyminium lilyminium merged commit c936089 into main Sep 8, 2023
@lilyminium lilyminium deleted the guard-toolkit-imports branch September 8, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not have top-level toolkit imports
2 participants
@lilyminium @codecov-commenter