Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add save function to GNNModel #29

Merged
merged 9 commits into from
Mar 9, 2023
Merged

Add save function to GNNModel #29

merged 9 commits into from
Mar 9, 2023

Conversation

lilyminium
Copy link
Collaborator

Fixes #

Changes made in this Pull Request:

  • Adds save function to mirror load function to GNNModel
  • Adds some docstrings

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Yoshanuikabundi
Yoshanuikabundi approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@Yoshanuikabundi Yoshanuikabundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Have added some clarifying remarks to GNNModel as we discussed in person.

openff/nagl/nn/_models.py Outdated Show resolved Hide resolved
openff/nagl/nn/_models.py Outdated Show resolved Hide resolved
lilyminium and others added 2 commits March 9, 2023 16:28
@lilyminium @Yoshanuikabundi
Update openff/nagl/nn/_models.py
b5f26db 
Co-authored-by: Josh A. Mitchell <[email protected]>
@lilyminium @Yoshanuikabundi
Update openff/nagl/nn/_models.py
2c12772 
Co-authored-by: Josh A. Mitchell <[email protected]>
@lilyminium lilyminium merged commit 83a625d into main Mar 9, 2023
@lilyminium lilyminium deleted the add-save branch March 9, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yoshanuikabundi Yoshanuikabundi Yoshanuikabundi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lilyminium @Yoshanuikabundi