Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RTD config #172

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Update RTD config #172

merged 1 commit into from
Jan 21, 2025

Conversation

mattwthompson
Copy link
Member

Fixes #171

Changes made in this Pull Request:

  • Updates RTD config using the toolkit's config as a reference

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@mattwthompson
Copy link
Member Author

Docs look okay: https://openff-docs--172.org.readthedocs.build/projects/nagl/en/172/

The warnings seem to be signal, not noise, but it might take more than trivial effort to fix all of them. I'd like this to be merged ~as-is and punt those fixes into the future

@mattwthompson
Update RTD config
012b974 
Allow warnings?
@mattwthompson mattwthompson marked this pull request as ready for review January 15, 2025 16:37
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.10%. Comparing base (b4ee21b) to head (012b974).
Report is 1 commits behind head on main.

Additional details and impacted files

@mattwthompson mattwthompson mentioned this pull request Jan 17, 2025
Closed
lilyminium
lilyminium approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @mattwthompson!

@lilyminium lilyminium mentioned this pull request Jan 20, 2025
Open
@mattwthompson mattwthompson merged commit ae50e54 into main Jan 21, 2025
134 checks passed
@mattwthompson mattwthompson mentioned this pull request Jan 21, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilyminium lilyminium lilyminium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sphinx.configuration key in ReadTheDocs is missing
3 participants
@mattwthompson @codecov-commenter @lilyminium