Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use defaults channel in environments #162

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Do not use defaults channel in environments #162

merged 1 commit into from
Nov 18, 2024

Conversation

mattwthompson
Copy link
Member

Fixes #158

Changes made in this Pull Request:

  • Do not use defaults channel in environments

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.23%. Comparing base (98dd835) to head (77a0c97).

Additional details and impacted files
---- 🚨 Try these New Features:

@mattwthompson mattwthompson marked this pull request as ready for review November 18, 2024 18:27
lilyminium
lilyminium approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this @mattwthompson!

@lilyminium lilyminium merged commit 92d3302 into main Nov 18, 2024
134 checks passed
@mattwthompson mattwthompson deleted the no-defaults-channel branch November 18, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilyminium lilyminium lilyminium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove defaults channel?
3 participants
@mattwthompson @codecov-commenter @lilyminium