Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add back 3.9 support" #105

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Conversation

mattwthompson
Copy link
Member

Reverts #89

NEP 29's 3.10+ standard drops today

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

Merging #105 (c4bd947) into main (7fb191c) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

@mattwthompson
Copy link
Member Author

Failures seem to just be #103

Comment on lines -39 to -42
exclude:
# broken OpenMM build for Mac on 3.10
- os: "macOS-latest"
python-version: "3.10"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to keep my changes minimal, but this exclusion seems to be outdated

@mattwthompson mattwthompson marked this pull request as ready for review April 5, 2024 17:31
Copy link
Collaborator

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @mattwthompson! Excited to see 3.9 go :-)

@lilyminium lilyminium merged commit 28387c1 into main Apr 8, 2024
59 of 62 checks passed
@lilyminium lilyminium deleted the revert-89-add-back-3.9-support branch April 8, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants