refactor(Products): show error message if product source unknown. ref #…

…1365
openfoodfacts · Feb 8, 2025 · 46bedd0 · 46bedd0
1 parent 99b3ba6
commit 46bedd0
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/src/components/ProductMissingChip.vue b/src/components/ProductMissingChip.vue
@@ -1,5 +1,5 @@
 <template>
   <v-chip label size="small" density="comfortable" color="error" data-name="product-missing-chip">
-    {{ $t('PriceCard.UnknownProduct') }}
+    {{ $t('Common.UnknownProduct') }}
   </v-chip>
 </template>
diff --git a/src/components/ProductSourceChip.vue b/src/components/ProductSourceChip.vue
@@ -1,5 +1,6 @@
 <template>
   <v-chip
+    v-if="hasProductSource"
     :style="style"
     label
     size="small"
@@ -10,6 +11,9 @@
       {{ getProductSourceName }}
     </v-tooltip>
   </v-chip>
+  <v-chip v-else label size="small" density="comfortable" color="error" data-name="product-source-missing-chip">
+    {{ $t('Common.UnknownSource') }}
+  </v-chip>
 </template>
 
 <script>
@@ -27,14 +31,17 @@ export default {
     },
   },
   computed: {
+    hasProductSource() {
+      return !!this.product.source
+    },
     getProductSourceIcon() {
-      if (this.product.source) {
+      if (this.hasProductSource) {
         return constants[`${this.product.source.toUpperCase()}_ICON`]
       }
       return null
     },
     getProductSourceName() {
-      if (this.product.source) {
+      if (this.hasProductSource) {
         return constants[`${this.product.source.toUpperCase()}_NAME`]
       }
       return null

diff --git a/src/i18n/locales/en.json b/src/i18n/locales/en.json
@@ -372,6 +372,9 @@
 		"Truncate": "Truncate",
 		"Truncated": "Truncated",
 		"Type": "Type",
+		"UnknownProduct":"Unknown product",
+		"UnknownProductSource": "Unknown product source",
+		"UnknownSource": "Unknown source",
 		"Unreadable": "Unreadable",
 		"Upload": "Upload",
 		"UploadMultipleImages": "Upload {count} image | Upload {count} images",