Update java11-vertx to use a shadow jar #286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Ellis (OpenFaaS Ltd) [email protected]
Description
Update java11-vertx to use a shadow jar
Motivation and Context
@koogordo suggested that using a shadow jar reduces the total size of functions using this template. Early testing showed up to 100MB in saving, and removed the zip/unzip stage from the build, making it quicker.
How Has This Been Tested?
Tested by running a docker build inside the template folder and running the container with docker, the code continued to work as expected.
Types of changes
Optimization, plus an upgrade to Gradle 7.3.3
Impact to existing users
The change in gradle version may mean changing "compile" to "implementation" within your gradle scripts.