Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Remove windows tray and installer #8778

Merged
merged 5 commits into from
Jun 6, 2018
Merged

Remove windows tray and installer #8778

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c7118e
Remove windows tray and installer
ascjones Jun 4, 2018
84a0a58
Remove make_exe (installer) target
ascjones Jun 4, 2018
9dc76fa
Change windows $ARC to amd64 for consistency
ascjones Jun 4, 2018
ec94fa0
Fix windows build - revert to winapi 0.2.8
ascjones Jun 4, 2018
5079918
Remove publishing of windows installer bins
ascjones Jun 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ windows:
- stable
- triggers
script:
- sh scripts/gitlab-build.sh x86_64-pc-windows-msvc x86_64-pc-windows-msvc installer "" "" windows
- sh scripts/gitlab-build.sh x86_64-pc-windows-msvc x86_64-pc-windows-msvc "" "" "" windows
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what (if anything) should be for the $ARC param instead of installer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ARC is just a string that goes into the binary name. I'm pretty sure it's unused after this PR, however, for consistency reasons, could you change it to amd64?

tags:
- rust-windows
artifacts:
Expand Down
191 changes: 0 additions & 191 deletions nsis/installer.nsi
View file
Open in desktop

This file was deleted.

Binary file removed nsis/logo.ico
View file
Open in desktop
Binary file not shown.
15 changes: 0 additions & 15 deletions scripts/gitlab-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ set_env_win () {
set RUST_BACKTRACE=1
#export RUSTFLAGS=$RUSTFLAGS
rustup default stable-x86_64-pc-windows-msvc
echo "MsBuild.exe windows\ptray\ptray.vcxproj /p:Platform=x64 /p:Configuration=Release" > msbuild.cmd
echo "@ signtool sign /f "\%"1 /p "\%"2 /tr http://timestamp.comodoca.com /du https://parity.io "\%"3" > sign.cmd
}
build () {
Expand Down Expand Up @@ -166,19 +165,6 @@ make_pkg () {
sign_exe () {
./sign.cmd $keyfile $certpass "target/$PLATFORM/release/parity.exe"
}
make_exe () {
./msbuild.cmd
./sign.cmd $keyfile $certpass windows/ptray/x64/release/ptray.exe
cd nsis
curl -sL --url "https://github.com/paritytech/win-build/raw/master/vc_redist.x64.exe" -o vc_redist.x64.exe
echo "makensis.exe installer.nsi" > nsis.cmd
./nsis.cmd
cd ..
cp nsis/installer.exe "parity_"$VER"_"$IDENT"_"$ARC"."$EXT
./sign.cmd $keyfile $certpass "parity_"$VER"_"$IDENT"_"$ARC"."$EXT
$MD5_BIN "parity_"$VER"_"$IDENT"_"$ARC"."$EXT -p %h > "parity_"$VER"_"$IDENT"_"$ARC"."$EXT".md5"
$SHA256_BIN "parity_"$VER"_"$IDENT"_"$ARC"."$EXT -p %h > "parity_"$VER"_"$IDENT"_"$ARC"."$EXT".sha256"
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT this is just installer/tray stuff so can be removed entirely.

push_binaries () {
echo "Push binaries to AWS S3"
aws configure set aws_access_key_id $s3_key
Expand Down Expand Up @@ -356,7 +342,6 @@ case $BUILD_PLATFORM in
build
sign_exe
calculate_checksums
make_exe
make_archive
push_binaries
updater_push_release
Expand Down
Loading