Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Removes FUTURE_QUEUE_LIMITS_SHIFT #6962

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Removes FUTURE_QUEUE_LIMITS_SHIFT #6962

merged 1 commit into from
Nov 2, 2017

Conversation

0x7CFE
Copy link
Contributor

@0x7CFE 0x7CFE commented Nov 2, 2017 •
edited
Loading

This PR removes FUTURE_QUEUE_LIMITS_SHIFT constant and its uses in transaction_queue.rs.

@tomusdrw, please make sure, that I didn't broke the should_limit_future_transactions and should_keep_right_order_in_future tests. Tests now pass, but their logic may be incorrect.

@0x7CFE 0x7CFE requested review from tomusdrw and arkpar November 2, 2017 06:43
tomusdrw
tomusdrw approved these changes Nov 2, 2017
View reviewed changes
Copy link
Collaborator

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explanation was to MAX_TX_TO_IMPORT in sync/src/chain.rs not this one, but it's still fine :)

@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. labels Nov 2, 2017
@0x7CFE
Copy link
Contributor Author

0x7CFE commented Nov 2, 2017

The explanation was to MAX_TX_TO_IMPORT in sync/src/chain.rs not this one, but it's still fine :)

Oops, sorry. Misread the chat logs.

@5chdn 5chdn added this to the 1.9 milestone Nov 2, 2017
@arkpar arkpar merged commit 713bba0 into master Nov 2, 2017
@arkpar arkpar deleted the fix_txqueue_limit branch November 2, 2017 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

@arkpar arkpar Awaiting requested review from arkpar

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
1.9 Velocity
Development

Successfully merging this pull request may close these issues.
4 participants
@0x7CFE @tomusdrw @arkpar @5chdn